Commit e64a63c3 authored by Rune Lillesveen's avatar Rune Lillesveen Committed by Commit Bot

No longer need to push bloom filters for layout tree building.

We used to push SelectorFilter for AttachLayoutTree when we did style
resolution there. The test in question used to fail DCHECKs. No longer
necessary for this test.

Change-Id: Icf7d7020d03c15dc446d18469971302915abbe89
Reviewed-on: https://chromium-review.googlesource.com/1218724Reviewed-by: default avatarAnders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590229}
parent 5c8bc84b
...@@ -39,8 +39,6 @@ class NodeTest : public EditingTestBase { ...@@ -39,8 +39,6 @@ class NodeTest : public EditingTestBase {
node.LazyReattachIfAttached(); node.LazyReattachIfAttached();
GetDocument().Lifecycle().AdvanceTo(DocumentLifecycle::kInStyleRecalc); GetDocument().Lifecycle().AdvanceTo(DocumentLifecycle::kInStyleRecalc);
GetDocument().GetStyleEngine().RecalcStyle(kNoChange); GetDocument().GetStyleEngine().RecalcStyle(kNoChange);
PushSelectorFilterAncestors(
GetDocument().EnsureStyleResolver().GetSelectorFilter(), node);
ReattachLegacyLayoutObjectList legacy_objects(GetDocument()); ReattachLegacyLayoutObjectList legacy_objects(GetDocument());
Node::AttachContext context; Node::AttachContext context;
node.ReattachLayoutTree(context); node.ReattachLayoutTree(context);
...@@ -67,14 +65,6 @@ class NodeTest : public EditingTestBase { ...@@ -67,14 +65,6 @@ class NodeTest : public EditingTestBase {
second_shadow.AppendChild(class_div); second_shadow.AppendChild(class_div);
return class_div; return class_div;
} }
private:
void PushSelectorFilterAncestors(SelectorFilter& filter, Node& node) {
if (Element* parent = FlatTreeTraversal::ParentElement(node)) {
PushSelectorFilterAncestors(filter, *parent);
filter.PushParent(*parent);
}
}
}; };
TEST_F(NodeTest, canStartSelection) { TEST_F(NodeTest, canStartSelection) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment