Commit e6685162 authored by Chris Lu's avatar Chris Lu Committed by Commit Bot

[ios] Turn on tests after fullscreen fix

Re-enable EG2Tests that were disabled because content was being hidden
behind the toolbar.

Bug: 1107989
Change-Id: I123bcab04934051b7475f9debcefc5b8c6a85497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354727Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798247}
parent e1de5c2f
...@@ -203,8 +203,7 @@ bool WaitForOpenInDownloadsButton() { ...@@ -203,8 +203,7 @@ bool WaitForOpenInDownloadsButton() {
} }
// Tests "Open in New Tab" on download link. // Tests "Open in New Tab" on download link.
// TODO(crbug.com/1107378): reenable this test. - (void)testDownloadInNewTab {
- (void)DISABLED_testDownloadInNewTab {
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")]; [ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Download"]; [ChromeEarlGrey waitForWebStateContainingText:"Download"];
......
...@@ -528,8 +528,7 @@ id<GREYMatcher> ResendPostButtonMatcher() { ...@@ -528,8 +528,7 @@ id<GREYMatcher> ResendPostButtonMatcher() {
// Tests that submitting a POST-based form by tapping the 'Go' button on the // Tests that submitting a POST-based form by tapping the 'Go' button on the
// keyboard navigates to the correct URL and the back button works as expected // keyboard navigates to the correct URL and the back button works as expected
// afterwards. // afterwards.
// TODO(crbug.com/1106741): reenable this test. - (void)testPostFormEntryWithKeyboard {
- (void)DISABLED_testPostFormEntryWithKeyboard {
// Test fails on iPad Air 2 13.4 crbug.com/1102608. // Test fails on iPad Air 2 13.4 crbug.com/1102608.
if ([ChromeEarlGrey isIPadIdiom] && base::ios::IsRunningOnOrLater(13, 0, 0)) { if ([ChromeEarlGrey isIPadIdiom] && base::ios::IsRunningOnOrLater(13, 0, 0)) {
EARL_GREY_TEST_DISABLED(@"Fails in iOS 13 on iPads."); EARL_GREY_TEST_DISABLED(@"Fails in iOS 13 on iPads.");
......
...@@ -47,8 +47,7 @@ const char kLinksTestURL2Text[] = "arrived"; ...@@ -47,8 +47,7 @@ const char kLinksTestURL2Text[] = "arrived";
@implementation TabOrderTestCase @implementation TabOrderTestCase
// Tests that new tabs are always inserted after their parent tab. // Tests that new tabs are always inserted after their parent tab.
// TODO(crbug.com/1106739): reenable this test. - (void)testChildTabOrdering {
- (void)DISABLED_testChildTabOrdering {
GREYAssertTrue(self.testServer->Start(), @"Test server failed to start."); GREYAssertTrue(self.testServer->Start(), @"Test server failed to start.");
const GURL URL1 = self.testServer->GetURL(kLinksTestURL1); const GURL URL1 = self.testServer->GetURL(kLinksTestURL1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment