Skip to content

GitLab

T
tangled
Commit e68681df authored by k.czech@samsung.com's avatar k.czech@samsung.com
Browse files
Options

Default orientation for aria scrollbars should be vertical 

Default orientation for aria scrollbars regarding http://www.w3.org/TR/wai-aria-1.1/#aria-orientation
and http://www.w3.org/TR/wai-aria-implementation/ should be vertical.

It's based on WebKit changeset http://trac.webkit.org/changeset/174217

BUG=

Review URL: https://codereview.chromium.org/723123002

git-svn-id: svn://svn.chromium.org/blink/trunk@185459 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 7297353e
Hide whitespace changes
Inline Side-by-side
Showing with 19 additions and 4 deletions
third_party/WebKit/LayoutTests/accessibility/aria-scrollbar-role-expected.txt
View file @ e68681df
scrollbar scrollbar
scrollbar
This tests that the ARIA scrollbar role works correctly This tests that the ARIA scrollbar role works correctly
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
...@@ -8,6 +9,9 @@ PASS scroller.role is 'AXRole: AXScrollBar' ...@@ -8,6 +9,9 @@ PASS scroller.role is 'AXRole: AXScrollBar'
PASS scroller.intValue is 55 PASS scroller.intValue is 55
PASS scroller.orientation is 'AXOrientation: AXVerticalOrientation' PASS scroller.orientation is 'AXOrientation: AXVerticalOrientation'
PASS scroller.orientation is 'AXOrientation: AXHorizontalOrientation' PASS scroller.orientation is 'AXOrientation: AXHorizontalOrientation'
PASS scroller.role is 'AXRole: AXScrollBar'
PASS scroller.intValue is 55
PASS scroller.orientation is 'AXOrientation: AXVerticalOrientation'
PASS successfullyParsed is true PASS successfullyParsed is true
TEST COMPLETE TEST COMPLETE
......
third_party/WebKit/LayoutTests/accessibility/aria-scrollbar-role.html
View file @ e68681df
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
</head> </head>
<body id="body"> <body id="body">
<div tabindex=0 id="scroller" aria-valuenow="55" role="scrollbar" aria-orientation="vertical">scrollbar</div> <div tabindex=0 id="scroller1" aria-valuenow="55" role="scrollbar" aria-orientation="vertical">scrollbar</div>
<div tabindex=0 id="scroller2" aria-valuenow="55" role="scrollbar">scrollbar</div>
<p id="description"></p> <p id="description"></p>
<div id="console"></div> <div id="console"></div>
...@@ -17,14 +17,22 @@ ...@@ -17,14 +17,22 @@
if (window.accessibilityController) { if (window.accessibilityController) {
document.getElementById("scroller").focus(); document.getElementById("scroller1").focus();
var scroller = accessibilityController.focusedElement; var scroller = accessibilityController.focusedElement;
shouldBe("scroller.role", "'AXRole: AXScrollBar'"); shouldBe("scroller.role", "'AXRole: AXScrollBar'");
shouldBe("scroller.intValue", "55"); shouldBe("scroller.intValue", "55");
shouldBe("scroller.orientation", "'AXOrientation: AXVerticalOrientation'"); shouldBe("scroller.orientation", "'AXOrientation: AXVerticalOrientation'");
document.getElementById("scroller").setAttribute("aria-orientation", "horizontal"); document.getElementById("scroller1").setAttribute("aria-orientation", "horizontal");
shouldBe("scroller.orientation", "'AXOrientation: AXHorizontalOrientation'"); shouldBe("scroller.orientation", "'AXOrientation: AXHorizontalOrientation'");
// Default orientation should be vertical for scrollbars
document.getElementById("scroller2").focus();
scroller = accessibilityController.focusedElement;
shouldBe("scroller.role", "'AXRole: AXScrollBar'");
shouldBe("scroller.intValue", "55");
shouldBe("scroller.orientation", "'AXOrientation: AXVerticalOrientation'");
} }
</script> </script>
......
third_party/WebKit/Source/modules/accessibility/AXRenderObject.cpp
View file @ e68681df
...@@ -855,6 +855,9 @@ AccessibilityOrientation AXRenderObject::orientation() const ...@@ -855,6 +855,9 @@ AccessibilityOrientation AXRenderObject::orientation() const
if (equalIgnoringCase(ariaOrientation, "vertical")) if (equalIgnoringCase(ariaOrientation, "vertical"))
return AccessibilityOrientationVertical; return AccessibilityOrientationVertical;
if (isScrollbar())
return AccessibilityOrientationVertical;
return AXObject::orientation(); return AXObject::orientation();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment