[iOS][Password Check] Record UserActions only for compormised passwords

PasswordManager.BulkCheck.UserAction should be recorded only if
password is compromised.

Bug: 1126415
Change-Id: I1a77e85f419735c59f8ee9ab3d42c58368b96097
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400984Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#805646}

ios/chrome/browser/ui/settings/password/password_details/password_details_coordinator.mm

@@ -150,7 +150,7 @@
 - (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin {
   NSString* message;
 
-  if (origin)
+  if (origin.length > 0)
     message =
         l10n_util::GetNSStringF(IDS_IOS_DELETE_COMPROMISED_PASSWORD_DESCRIPTION,
                                 base::SysNSStringToUTF16(origin));
@@ -167,13 +167,9 @@
   [self.actionSheetCoordinator
       addItemWithTitle:l10n_util::GetNSString(IDS_IOS_CONFIRM_PASSWORD_DELETION)
                 action:^{
-                  [weakSelf.delegate
-                      passwordDetailsCoordinator:weakSelf
-                                  deletePassword:weakSelf.mediator.password];
-                  base::UmaHistogramEnumeration(
-                      "PasswordManager.BulkCheck.UserAction",
-                      password_manager::metrics_util::PasswordCheckInteraction::
-                          kRemovePassword);
+                  [weakSelf
+                      passwordDeletionConfirmedForCompromised:origin.length >
+                                                              0];
                 }
                  style:UIAlertActionStyleDestructive];
 
@@ -213,4 +209,18 @@
   [self.actionSheetCoordinator start];
 }
 
+#pragma mark - Private
+
+// Notifies delegate about password deletion and records metric if needed.
+- (void)passwordDeletionConfirmedForCompromised:(BOOL)compromised {
+  [self.delegate passwordDetailsCoordinator:self
+                             deletePassword:self.mediator.password];
+  if (compromised) {
+    base::UmaHistogramEnumeration(
+        "PasswordManager.BulkCheck.UserAction",
+        password_manager::metrics_util::PasswordCheckInteraction::
+            kRemovePassword);
+  }
+}
+
 @end

ios/chrome/browser/ui/settings/password/password_details/password_details_table_view_controller.mm

@@ -444,8 +444,10 @@ typedef NS_ENUM(NSInteger, ReauthenticationReason) {
           [[UIImage imageNamed:@"infobar_hide_password_icon"]
               imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate];
       [self reconfigureCellsForItems:@[ self.passwordTextItem ]];
-      UmaHistogramEnumeration("PasswordManager.BulkCheck.UserAction",
-                              PasswordCheckInteraction::kShowPassword);
+      if (self.password.compromised) {
+        UmaHistogramEnumeration("PasswordManager.BulkCheck.UserAction",
+                                PasswordCheckInteraction::kShowPassword);
+      }
       break;
     case ReauthenticationReasonCopy: {
       UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];
@@ -496,8 +498,10 @@ typedef NS_ENUM(NSInteger, ReauthenticationReason) {
   [self.delegate passwordDetailsViewController:self
                         didEditPasswordDetails:self.password];
   [super editButtonPressed];
-  UmaHistogramEnumeration("PasswordManager.BulkCheck.UserAction",
-                          PasswordCheckInteraction::kEditPassword);
+  if (self.password.compromised) {
+    UmaHistogramEnumeration("PasswordManager.BulkCheck.UserAction",
+                            PasswordCheckInteraction::kEditPassword);
+  }
   [self reloadData];
 }