Initialize the WRL::Module only once.
The issue with the crashing code is that on the RPC client side of the updater, both update and control services must be instantiated. They both called WRL::Module::Create, which caused WRL code to assert. The server side of RPC also initializes the module, in a slightly different way. Therefore, module initialization in the App base class is not practical. It has to be done in a way specific to the client, or the server, or the mode App is instantiated as. Using a leaky singleton is not great. However, there is singleton already in the WRL::Module, so a leaking singleton in the updater just shows that fact. Bug: 1128748 Change-Id: I646c5ef779c4affe7f2fe8f751d1dea1f16f8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414847Reviewed-by:S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807682}
Showing
Please register or sign in to comment