Commit e6972302 authored by Sergey Ulanov's avatar Sergey Ulanov Committed by Commit Bot

[Fuchsia] Fix DCHECK when destroying FuchsiaVideoDecoder.

FuchsiaVideoDecoder was crashing with a DCHECK in SendInputPacket()
while being destroyed  because in_flight_input_packets_ were cleared
while there is pending data in the queue, which was causing new input
packets to be produced. Added ReleaseInputBuffers() call in
~FuchsiaVideoDecoder() to avoid this issue.

Bug: 1013919
Change-Id: Id455e97ad8dad70d6aaa7dfc1bbee0426df7ae48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898777
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712661}
parent 1d0f95c1
...@@ -315,6 +315,11 @@ FuchsiaVideoDecoder::FuchsiaVideoDecoder( ...@@ -315,6 +315,11 @@ FuchsiaVideoDecoder::FuchsiaVideoDecoder(
} }
FuchsiaVideoDecoder::~FuchsiaVideoDecoder() { FuchsiaVideoDecoder::~FuchsiaVideoDecoder() {
// Call ReleaseInputBuffers() to make sure the corresponding fields are
// destroyed in the right order.
ReleaseInputBuffers();
// Release mailboxes used for output frames.
ReleaseOutputBuffers(); ReleaseOutputBuffers();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment