Commit e6ad8b42 authored by Stephen Martinis's avatar Stephen Martinis Committed by Commit Bot

Revert "Reland "Parallelize fetching telemetry benchmark deps""

This reverts commit 95e22d39.

Reason for revert: Potentially breaking many builders, https://crbug.com/1108314

Original change's description:
> Reland "Parallelize fetching telemetry benchmark deps"
>
> This is a reland of 8ab0b856
>
> Original change's description:
> > Parallelize fetching telemetry benchmark deps
> >
> > The fetching script currently fetches about 2 GB (on my linux workstation)
> > from cloud storage serially. This can (and is) trivially parallelizable, and
> > should speed up the fetching script significantly.
> >
> > This script has been taking 20 minutes on mac machines for a long time. This
> > will hopefully significantly speed the mac builders up.
> >
> > Bug: 1102597
> > Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#786521}
>
> Bug: 1102597
> Change-Id: I37d0055fadb26bf4eae2b0b5fe0ecc4732edde3d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288740
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#789736}

TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

# Tree is currently closed, trying to fix an outage

No-Try: true
No-Tree-Checks: true
Bug: 1102597
Change-Id: If6b95395208a3136a798118e4eb229e4322c7878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317774
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: default avatarStephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791304}
parent d6e7764f
...@@ -7,11 +7,10 @@ ...@@ -7,11 +7,10 @@
import argparse import argparse
import json import json
import logging
import multiprocessing
import optparse import optparse
import os import os
import sys import sys
import logging
from chrome_telemetry_build import chromium_config from chrome_telemetry_build import chromium_config
from core import benchmark_finders from core import benchmark_finders
...@@ -122,12 +121,8 @@ def main(args): ...@@ -122,12 +121,8 @@ def main(args):
raw_input( raw_input(
'No benchmark name is specified. Fetching all benchmark deps. ' 'No benchmark name is specified. Fetching all benchmark deps. '
'Press enter to continue...') 'Press enter to continue...')
benchmarks = benchmark_finders.GetOfficialBenchmarks() for b in benchmark_finders.GetOfficialBenchmarks():
p = multiprocessing.Pool() deps[b.Name()] = _FetchDepsForBenchmark(b)
results = p.map(_FetchDepsForBenchmark, benchmarks)
p.terminate()
for benchmark, result in zip(benchmarks, results):
deps[benchmark.Name()] = result
if options.output_deps: if options.output_deps:
with open(options.output_deps, 'w') as outfile: with open(options.output_deps, 'w') as outfile:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment