Commit e6bb68b6 authored by Jinho Bang's avatar Jinho Bang Committed by Commit Bot

PaymentRequest: Add [NewObject] annotations to methods

Methods, like .complete(), show(), etc. always return a new object. They
should probably be marked as [NewObject].

This is no behavior change. So, no requires a "intent to implement".

Releated spec change:
  https://github.com/w3c/payment-request/pull/746

Bug: none
Change-Id: Ib4646a77ab7426310c42011d69c410ef104a91a4
Reviewed-on: https://chromium-review.googlesource.com/1128825Reviewed-by: default avatarGanggui Tang <gogerald@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#573546}
parent 1f2e0a08
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
Exposed=Window, Exposed=Window,
ActiveScriptWrappable ActiveScriptWrappable
] interface PaymentRequest : EventTarget { ] interface PaymentRequest : EventTarget {
[CallWith=ScriptState] Promise<PaymentResponse> show(); [CallWith=ScriptState, NewObject] Promise<PaymentResponse> show();
[CallWith=ScriptState] Promise<void> abort(); [CallWith=ScriptState, NewObject] Promise<void> abort();
[CallWith=ScriptState] Promise<boolean> canMakePayment(); [CallWith=ScriptState, NewObject] Promise<boolean> canMakePayment();
readonly attribute DOMString id; readonly attribute DOMString id;
[ImplementedAs=getShippingAddress] readonly attribute PaymentAddress? shippingAddress; [ImplementedAs=getShippingAddress] readonly attribute PaymentAddress? shippingAddress;
......
...@@ -28,5 +28,5 @@ enum PaymentComplete { ...@@ -28,5 +28,5 @@ enum PaymentComplete {
readonly attribute DOMString? payerEmail; readonly attribute DOMString? payerEmail;
readonly attribute DOMString? payerPhone; readonly attribute DOMString? payerPhone;
[CallWith=ScriptState] Promise<void> complete(optional PaymentComplete paymentResult = "unknown"); [CallWith=ScriptState, NewObject] Promise<void> complete(optional PaymentComplete paymentResult = "unknown");
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment