Commit e6e1e1b5 authored by Owen Min's avatar Owen Min Committed by Commit Bot

Disable two TestConfirmDialogDefaultGCCancel tests

Disable WebViewTest, Dialog_TestConfirmDialogDefaultGCCancel on
Win, Linux and ChromeOS
Disable WebViewAPITest.TestDialogConfirmDefaultGCCancel on
all platforms

These tests are timeout.

Bug: 937461
Tbr: lfg@chromium.org
Change-Id: I46d846e07ae04ed9077fb9a167f3fe625b335c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937667
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: default avatarOwen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719461}
parent 2e7d2bd1
......@@ -3155,7 +3155,16 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Dialog_TestConfirmDialogDefaultCancel) {
NO_TEST_SERVER);
}
IN_PROC_BROWSER_TEST_F(WebViewTest, Dialog_TestConfirmDialogDefaultGCCancel) {
// Disable due to runloop time out. https://crbug.com/937461
#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_CHROMEOS)
#define MAYBE_Dialog_TestConfirmDialogDefaultGCCancel \
DISABLED_Dialog_TestConfirmDialogDefaultGCCancel
#else
#define MAYBE_Dialog_TestConfirmDialogDefaultGCCancel \
Dialog_TestConfirmDialogDefaultGCCancel
#endif
IN_PROC_BROWSER_TEST_F(WebViewTest,
MAYBE_Dialog_TestConfirmDialogDefaultGCCancel) {
TestHelper("testConfirmDialogDefaultGCCancel",
"web_view/dialog",
NO_TEST_SERVER);
......
......@@ -525,16 +525,10 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDialogConfirmDefaultCancel) {
RunTest("testDialogConfirmDefaultCancel", "web_view/dialog");
}
// This test is flaky and times out on windows.
// This test is flaky and times out on all platforms.
// https://crbug.com/937461.
#if defined(OS_WIN)
#define MAYBE_TestDialogConfirmDefaultGCCancel \
DISABLED_TestDialogConfirmDefaultGCCancel
#else
#define MAYBE_TestDialogConfirmDefaultGCCancel TestDialogConfirmDefaultGCCancel
#endif
IN_PROC_BROWSER_TEST_F(WebViewAPITest, MAYBE_TestDialogConfirmDefaultGCCancel) {
IN_PROC_BROWSER_TEST_F(WebViewAPITest,
DISABLED_TestDialogConfirmDefaultGCCancel) {
RunTest("testDialogConfirmDefaultGCCancel", "web_view/dialog");
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment