Commit e6e289cb authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

ios: Speculative deflake for testLinkWithBlankTargetWithDelayedClose.

If EarlGrey takes too long to detect a waiting state after
tapWebStateElementWithID the second tab may have already closed.

Increase the delay to close the tab, and to wait in the test.

Bug: 1121505
Change-Id: Ib92ad4342244d95db4a888898cb7564b987fda45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375727Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801510}
parent 4b039a0e
...@@ -204,7 +204,7 @@ id<GREYMatcher> PopupBlocker() { ...@@ -204,7 +204,7 @@ id<GREYMatcher> PopupBlocker() {
[ChromeEarlGrey [ChromeEarlGrey
tapWebStateElementWithID:@"webScenarioWindowOpenWithDelayedClose"]; tapWebStateElementWithID:@"webScenarioWindowOpenWithDelayedClose"];
[ChromeEarlGrey waitForMainTabCount:2]; [ChromeEarlGrey waitForMainTabCount:2];
base::test::ios::SpinRunLoopWithMinDelay(base::TimeDelta::FromSecondsD(1)); base::test::ios::SpinRunLoopWithMinDelay(base::TimeDelta::FromSecondsD(5));
[ChromeEarlGrey waitForMainTabCount:1]; [ChromeEarlGrey waitForMainTabCount:1];
} }
......
...@@ -218,7 +218,7 @@ found in the LICENSE file. --> ...@@ -218,7 +218,7 @@ found in the LICENSE file. -->
<tr id="_webScenarioWindowOpenWithDelayedClose"> <tr id="_webScenarioWindowOpenWithDelayedClose">
<td> <td>
<a href="window_close.html#2" <a href="window_close.html#5"
target="_blank" target="_blank"
name="webScenarioWindowOpenWithDelayedClose" name="webScenarioWindowOpenWithDelayedClose"
id="webScenarioWindowOpenWithDelayedClose"> id="webScenarioWindowOpenWithDelayedClose">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment