Commit e70a0617 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Make FileVersionInfoTest.NoVersionInfo 64-bit only.

https://crrev.com/702886 checked in a 64-bit DLL for testing, which does
not work on 32-bit bots. Temporarily mark the test 64-bit only, so the
32-bit Windows bots go green.

TBR=grt@chromium.org

Bug: 1011439
Change-Id: I0a64a10bfa785c4033bb2a626941d7ea42bac526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841657Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703039}
parent a2d7244a
......@@ -16,6 +16,7 @@
#include "base/path_service.h"
#include "base/scoped_native_library.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::FilePath;
......@@ -157,6 +158,9 @@ TYPED_TEST(FileVersionInfoTest, CustomProperties) {
version_info_win->GetFileVersion());
}
#if defined(ARCH_CPU_64_BITS)
// TODO(bug_1011439): Change no_version_info.dll to 32 bit, so this test will
// work for 32-bit Windows as well.
TYPED_TEST(FileVersionInfoTest, NoVersionInfo) {
FilePath dll_path = GetTestDataPath();
dll_path = dll_path.AppendASCII("no_version_info.dll");
......@@ -164,3 +168,4 @@ TYPED_TEST(FileVersionInfoTest, NoVersionInfo) {
TypeParam factory(dll_path);
ASSERT_FALSE(factory.Create());
}
#endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment