Commit e70bdb7d authored by sashab@chromium.org's avatar sashab@chromium.org

Disable the App Info Dialog from displaying for the Genius app

Disable the App Info Dialog from being selectable for the Genius app,
which shows as a 'Get Help' link in the app launcher (and doesn't have
a proper description/proper metadata).

BUG=383713

Review URL: https://codereview.chromium.org/329383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276709 0039d316-1c4b-4281-b951-d872f2087c98
parent 22184780
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "chrome/app/chrome_command_ids.h" #include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/chromeos/genius_app/app_id.h"
#include "chrome/browser/extensions/context_menu_matcher.h" #include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h" #include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h" #include "chrome/browser/prefs/incognito_mode_prefs.h"
...@@ -116,9 +117,12 @@ ui::MenuModel* AppContextMenu::GetMenuModel() { ...@@ -116,9 +117,12 @@ ui::MenuModel* AppContextMenu::GetMenuModel() {
IDS_NEW_TAB_APP_CREATE_SHORTCUT); IDS_NEW_TAB_APP_CREATE_SHORTCUT);
} }
// Don't display the app info dialog for the web store app. // Don't display the app info dialog for the Store app or the Genius app.
// TODO(sashab): Update the metadata for these apps so their dialogs can be
// re-enabled (see crbug.com/383713).
if (controller_->CanDoShowAppInfoFlow() && if (controller_->CanDoShowAppInfoFlow() &&
app_id_ != extension_misc::kWebStoreAppId) { app_id_ != extension_misc::kWebStoreAppId &&
app_id_ != genius_app::kGeniusAppId) {
menu_model_->AddItemWithStringId(SHOW_APP_INFO, menu_model_->AddItemWithStringId(SHOW_APP_INFO,
IDS_APP_CONTEXT_MENU_SHOW_INFO); IDS_APP_CONTEXT_MENU_SHOW_INFO);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment