Commit e72070d6 authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

DumpWithoutCrashing on mismatched navigation_token at DidCommit

We changed it into a DCHECK in crrev.com/c/2478744, but not really sure
if this can happen IRL or not, so adding DumpWithoutCrashing here to
see if we can turn it into a CHECK eventually.

Bug: 1131832
Change-Id: Ia8974f218fae4aada933cbabb3f59163ccc0e03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522791
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825643}
parent 2d61dc7b
......@@ -8576,9 +8576,20 @@ bool RenderFrameHostImpl::DidCommitNavigationInternal(
bool is_same_document_navigation) {
// Sanity-check the page transition for frame type.
DCHECK_EQ(ui::PageTransitionIsMainFrame(params->transition), !GetParent());
if (navigation_request) {
DCHECK_EQ(navigation_request->commit_params().navigation_token,
params->navigation_token);
if (navigation_request &&
navigation_request->commit_params().navigation_token !=
params->navigation_token) {
// We should have the same navigation_token in CommitNavigationParams and
// DidCommit's |params| for all navigations, because:
// - Cross-document navigations use NavigationClient.
// - Same-document navigations will have a null |navigation_request|
// here if the navigation_token doesn't match (checked in
// DidCommitSameDocumentNavigation).
// TODO(https://crbug.com/1131832): Make this a CHECK instead once we're
// sure we never hit this case.
LogCannotCommitUrlCrashKeys(params->url, is_same_document_navigation,
navigation_request.get());
base::debug::DumpWithoutCrashing();
}
if (!navigation_request) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment