Commit e743a2b9 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix instances of bugprone-argument-comment

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: I6c89922f34472a5e06fb88b68ecbf5996de37c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459051Reviewed-by: default avatarMaksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815673}
parent 8e48128a
...@@ -586,7 +586,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, ...@@ -586,7 +586,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
histogram_tester.ExpectBucketCount( histogram_tester.ExpectBucketCount(
"Sync.ProblematicServerSideBookmarks", "Sync.ProblematicServerSideBookmarks",
/*sample=*/ExpectedRemoteBookmarkUpdateError::kInvalidSpecifics, /*sample=*/ExpectedRemoteBookmarkUpdateError::kInvalidSpecifics,
/*count=*/1); /*expected_count=*/1);
} }
TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
...@@ -620,7 +620,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, ...@@ -620,7 +620,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
histogram_tester.ExpectBucketCount( histogram_tester.ExpectBucketCount(
"Sync.ProblematicServerSideBookmarks", "Sync.ProblematicServerSideBookmarks",
/*sample=*/ExpectedRemoteBookmarkUpdateError::kUnexpectedGuid, /*sample=*/ExpectedRemoteBookmarkUpdateError::kUnexpectedGuid,
/*count=*/1); /*expected_count=*/1);
} }
TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
...@@ -675,7 +675,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, ...@@ -675,7 +675,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
histogram_tester.ExpectBucketCount( histogram_tester.ExpectBucketCount(
"Sync.ProblematicServerSideBookmarks", "Sync.ProblematicServerSideBookmarks",
/*sample=*/ExpectedRemoteBookmarkUpdateError::kUnexpectedGuid, /*sample=*/ExpectedRemoteBookmarkUpdateError::kUnexpectedGuid,
/*count=*/0); /*expected_count=*/0);
} }
TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
...@@ -1015,7 +1015,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, ...@@ -1015,7 +1015,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
histogram_tester.ExpectBucketCount( histogram_tester.ExpectBucketCount(
"Sync.ProblematicServerSideBookmarks", "Sync.ProblematicServerSideBookmarks",
/*sample=*/ExpectedRemoteBookmarkUpdateError::kParentNotFolder, /*sample=*/ExpectedRemoteBookmarkUpdateError::kParentNotFolder,
/*count=*/1); /*expected_count=*/1);
} }
TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
...@@ -1896,7 +1896,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, ...@@ -1896,7 +1896,7 @@ TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
/*sample=*/ /*sample=*/
BookmarkRemoteUpdatesHandler:: BookmarkRemoteUpdatesHandler::
DuplicateBookmarkEntityOnRemoteUpdateCondition::kServerIdTombstone, DuplicateBookmarkEntityOnRemoteUpdateCondition::kServerIdTombstone,
/*count=*/1); /*expected_count=*/1);
} }
TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest, TEST_F(BookmarkRemoteUpdatesHandlerWithInitialMergeTest,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment