[css-flex] Remove flex gaps flags

Flex gaps had no problems in the M84 rollout.

Bug: 762679
Change-Id: Ib776156c3344998cb460feb24e224d0281321966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334471
Commit-Queue: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794242}

content/child/runtime_features.cc

@@ -378,7 +378,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
            kUseFeatureState},
           {"FeaturePolicyForClientHints",
            features::kFeaturePolicyForClientHints, kUseFeatureState},
-          {"FlexGaps", blink::features::kFlexGaps, kEnableOnly},
           {"FontAccess", blink::features::kFontAccess, kUseFeatureState},
           {"FontSrcLocalMatching", features::kFontSrcLocalMatching,
            kUseFeatureState},

third_party/blink/common/features.cc

@@ -567,7 +567,6 @@ const base::Feature kFontPreloadingDelaysRendering{
 const base::FeatureParam<int> kFontPreloadingDelaysRenderingParam{
     &kFontPreloadingDelaysRendering, "delay-in-ms", 50};
 
-const base::Feature kFlexGaps{"FlexGaps", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kFlexNG{"FlexNG", base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kKeepScriptResourceAlive{"KeepScriptResourceAlive",

third_party/blink/public/common/features.h

@@ -181,7 +181,6 @@ BLINK_COMMON_EXPORT extern const base::Feature kFontPreloadingDelaysRendering;
 BLINK_COMMON_EXPORT extern const base::FeatureParam<int>
     kFontPreloadingDelaysRenderingParam;
 
-BLINK_COMMON_EXPORT extern const base::Feature kFlexGaps;
 BLINK_COMMON_EXPORT extern const base::Feature kFlexNG;
 
 BLINK_COMMON_EXPORT extern const base::Feature kKeepScriptResourceAlive;

third_party/blink/renderer/core/layout/flexible_box_algorithm.cc

@@ -586,8 +586,6 @@ void FlexLine::ComputeLineItemsPosition(LayoutUnit main_axis_start_offset,
 LayoutUnit FlexLayoutAlgorithm::GapBetweenItems(
     const ComputedStyle& style,
     LogicalSize percent_resolution_sizes) {
-  if (!RuntimeEnabledFeatures::FlexGapsEnabled())
-    return LayoutUnit();
   DCHECK_GE(percent_resolution_sizes.inline_size, 0);
   if (IsColumnFlow(style)) {
     if (const base::Optional<Length>& row_gap = style.RowGap()) {
@@ -607,8 +605,6 @@ LayoutUnit FlexLayoutAlgorithm::GapBetweenItems(
 LayoutUnit FlexLayoutAlgorithm::GapBetweenLines(
     const ComputedStyle& style,
     LogicalSize percent_resolution_sizes) {
-  if (!RuntimeEnabledFeatures::FlexGapsEnabled())
-    return LayoutUnit();
   DCHECK_GE(percent_resolution_sizes.inline_size, 0);
   if (!IsColumnFlow(style)) {
     if (const base::Optional<Length>& row_gap = style.RowGap()) {

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -786,10 +786,6 @@
       name: "FileSystem",
       status: "stable",
     },
-    {
-      name: "FlexGaps",
-      status: "stable",
-    },
     {
       name: "FocuslessSpatialNavigation",
       settable_from_internals: true,