Spelling correction: "nonexistant" -> "nonexistent".

BUG=none
TEST=good spellers are slightly happier

Review URL: http://codereview.chromium.org/3143037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
parent ac1894ae
// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -122,7 +122,7 @@ bool Connection::BeginTransaction() { ...@@ -122,7 +122,7 @@ bool Connection::BeginTransaction() {
void Connection::RollbackTransaction() { void Connection::RollbackTransaction() {
if (!transaction_nesting_) { if (!transaction_nesting_) {
NOTREACHED() << "Rolling back a nonexistant transaction"; NOTREACHED() << "Rolling back a nonexistent transaction";
return; return;
} }
...@@ -139,7 +139,7 @@ void Connection::RollbackTransaction() { ...@@ -139,7 +139,7 @@ void Connection::RollbackTransaction() {
bool Connection::CommitTransaction() { bool Connection::CommitTransaction() {
if (!transaction_nesting_) { if (!transaction_nesting_) {
NOTREACHED() << "Rolling back a nonexistant transaction"; NOTREACHED() << "Rolling back a nonexistent transaction";
return false; return false;
} }
transaction_nesting_--; transaction_nesting_--;
......
// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -91,7 +91,7 @@ TEST_F(SQLConnectionTest, DoesStuffExist) { ...@@ -91,7 +91,7 @@ TEST_F(SQLConnectionTest, DoesStuffExist) {
EXPECT_FALSE(db().DoesColumnExist("foo", "bar")); EXPECT_FALSE(db().DoesColumnExist("foo", "bar"));
EXPECT_TRUE(db().DoesColumnExist("foo", "a")); EXPECT_TRUE(db().DoesColumnExist("foo", "a"));
// Testing for a column on a nonexistant table. // Testing for a column on a nonexistent table.
EXPECT_FALSE(db().DoesColumnExist("bar", "b")); EXPECT_FALSE(db().DoesColumnExist("bar", "b"));
} }
......
// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -30,7 +30,7 @@ bool Transaction::Begin() { ...@@ -30,7 +30,7 @@ bool Transaction::Begin() {
void Transaction::Rollback() { void Transaction::Rollback() {
if (!is_open_) { if (!is_open_) {
NOTREACHED() << "Attempting to roll back a nonexistant transaction. " NOTREACHED() << "Attempting to roll back a nonexistent transaction. "
<< "Did you remember to call Begin() and check its return?"; << "Did you remember to call Begin() and check its return?";
return; return;
} }
...@@ -40,7 +40,7 @@ void Transaction::Rollback() { ...@@ -40,7 +40,7 @@ void Transaction::Rollback() {
bool Transaction::Commit() { bool Transaction::Commit() {
if (!is_open_) { if (!is_open_) {
NOTREACHED() << "Attempting to commit a nonexistant transaction. " NOTREACHED() << "Attempting to commit a nonexistent transaction. "
<< "Did you remember to call Begin() and check its return?"; << "Did you remember to call Begin() and check its return?";
return false; return false;
} }
......
...@@ -428,7 +428,7 @@ TEST_F(FileUtilTest, NormalizeFilePathBasic) { ...@@ -428,7 +428,7 @@ TEST_F(FileUtilTest, NormalizeFilePathBasic) {
ASSERT_FALSE(file_util::PathExists(file_a_path)); ASSERT_FALSE(file_util::PathExists(file_a_path));
ASSERT_FALSE(file_util::NormalizeFilePath(file_a_path, ASSERT_FALSE(file_util::NormalizeFilePath(file_a_path,
&normalized_file_a_path)) &normalized_file_a_path))
<< "NormalizeFilePath() should fail on nonexistant paths."; << "NormalizeFilePath() should fail on nonexistent paths.";
CreateTextFile(file_a_path, bogus_content); CreateTextFile(file_a_path, bogus_content);
ASSERT_TRUE(file_util::PathExists(file_a_path)); ASSERT_TRUE(file_util::PathExists(file_a_path));
......
...@@ -297,7 +297,7 @@ class CancelableRequestConsumerTSimple : public CancelableRequestConsumerBase { ...@@ -297,7 +297,7 @@ class CancelableRequestConsumerTSimple : public CancelableRequestConsumerBase {
typename PendingRequestList::iterator i = typename PendingRequestList::iterator i =
pending_requests_.find(PendingRequest(provider, handle)); pending_requests_.find(PendingRequest(provider, handle));
if (i == pending_requests_.end()) { if (i == pending_requests_.end()) {
NOTREACHED() << "Got a complete notification for a nonexistant request"; NOTREACHED() << "Got a complete notification for a nonexistent request";
return; return;
} }
......
...@@ -406,7 +406,7 @@ void ExtensionsService::UninstallExtension(const std::string& extension_id, ...@@ -406,7 +406,7 @@ void ExtensionsService::UninstallExtension(const std::string& extension_id,
bool external_uninstall) { bool external_uninstall) {
Extension* extension = GetExtensionByIdInternal(extension_id, true, true); Extension* extension = GetExtensionByIdInternal(extension_id, true, true);
// Callers should not send us nonexistant extensions. // Callers should not send us nonexistent extensions.
DCHECK(extension); DCHECK(extension);
// Notify interested parties that we're uninstalling this extension. // Notify interested parties that we're uninstalling this extension.
...@@ -901,7 +901,7 @@ void ExtensionsService::UnloadExtension(const std::string& extension_id) { ...@@ -901,7 +901,7 @@ void ExtensionsService::UnloadExtension(const std::string& extension_id) {
scoped_ptr<Extension> extension( scoped_ptr<Extension> extension(
GetExtensionByIdInternal(extension_id, true, true)); GetExtensionByIdInternal(extension_id, true, true));
// Callers should not send us nonexistant extensions. // Callers should not send us nonexistent extensions.
CHECK(extension.get()); CHECK(extension.get());
// Keep information about the extension so that we can reload it later // Keep information about the extension so that we can reload it later
......
...@@ -891,7 +891,7 @@ TEST_F(ExpireHistoryTest, ArchiveSomeOldHistoryWithSource) { ...@@ -891,7 +891,7 @@ TEST_F(ExpireHistoryTest, ArchiveSomeOldHistoryWithSource) {
} }
// TODO(brettw) add some visits with no URL to make sure everything is updated // TODO(brettw) add some visits with no URL to make sure everything is updated
// properly. Have the visits also refer to nonexistant FTS rows. // properly. Have the visits also refer to nonexistent FTS rows.
// //
// Maybe also refer to invalid favicons. // Maybe also refer to invalid favicons.
......
// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -67,9 +67,9 @@ class URLDatabaseTest : public testing::Test, ...@@ -67,9 +67,9 @@ class URLDatabaseTest : public testing::Test,
sql::Connection db_; sql::Connection db_;
}; };
// Test add and query for the URL table in the HistoryDatabase // Test add and query for the URL table in the HistoryDatabase.
TEST_F(URLDatabaseTest, AddURL) { TEST_F(URLDatabaseTest, AddURL) {
// first, add two URLs // First, add two URLs.
const GURL url1("http://www.google.com/"); const GURL url1("http://www.google.com/");
URLRow url_info1(url1); URLRow url_info1(url1);
url_info1.set_title(UTF8ToUTF16("Google")); url_info1.set_title(UTF8ToUTF16("Google"));
...@@ -88,7 +88,7 @@ TEST_F(URLDatabaseTest, AddURL) { ...@@ -88,7 +88,7 @@ TEST_F(URLDatabaseTest, AddURL) {
url_info2.set_hidden(true); url_info2.set_hidden(true);
EXPECT_TRUE(AddURL(url_info2)); EXPECT_TRUE(AddURL(url_info2));
// query both of them // Query both of them.
URLRow info; URLRow info;
EXPECT_TRUE(GetRowForURL(url1, &info)); EXPECT_TRUE(GetRowForURL(url1, &info));
EXPECT_TRUE(IsURLRowEqual(url_info1, info)); EXPECT_TRUE(IsURLRowEqual(url_info1, info));
...@@ -96,7 +96,7 @@ TEST_F(URLDatabaseTest, AddURL) { ...@@ -96,7 +96,7 @@ TEST_F(URLDatabaseTest, AddURL) {
EXPECT_TRUE(id2); EXPECT_TRUE(id2);
EXPECT_TRUE(IsURLRowEqual(url_info2, info)); EXPECT_TRUE(IsURLRowEqual(url_info2, info));
// update the second // Update the second.
url_info2.set_title(UTF8ToUTF16("Google Mail Too")); url_info2.set_title(UTF8ToUTF16("Google Mail Too"));
url_info2.set_visit_count(4); url_info2.set_visit_count(4);
url_info2.set_typed_count(1); url_info2.set_typed_count(1);
...@@ -104,19 +104,19 @@ TEST_F(URLDatabaseTest, AddURL) { ...@@ -104,19 +104,19 @@ TEST_F(URLDatabaseTest, AddURL) {
url_info2.set_hidden(false); url_info2.set_hidden(false);
EXPECT_TRUE(UpdateURLRow(id2, url_info2)); EXPECT_TRUE(UpdateURLRow(id2, url_info2));
// make sure it got updated // Make sure it got updated.
URLRow info2; URLRow info2;
EXPECT_TRUE(GetRowForURL(url2, &info2)); EXPECT_TRUE(GetRowForURL(url2, &info2));
EXPECT_TRUE(IsURLRowEqual(url_info2, info2)); EXPECT_TRUE(IsURLRowEqual(url_info2, info2));
// query a nonexistant URL // Query a nonexistent URL.
EXPECT_EQ(0, GetRowForURL(GURL("http://news.google.com/"), &info)); EXPECT_EQ(0, GetRowForURL(GURL("http://news.google.com/"), &info));
// Delete all urls in the domain // Delete all urls in the domain.
// TODO(acw): test the new url based delete domain // TODO(acw): test the new url based delete domain
// EXPECT_TRUE(db.DeleteDomain(kDomainID)); // EXPECT_TRUE(db.DeleteDomain(kDomainID));
// Make sure the urls have been properly removed // Make sure the urls have been properly removed.
// TODO(acw): commented out because remove no longer works. // TODO(acw): commented out because remove no longer works.
// EXPECT_TRUE(db.GetURLInfo(url1, NULL) == NULL); // EXPECT_TRUE(db.GetURLInfo(url1, NULL) == NULL);
// EXPECT_TRUE(db.GetURLInfo(url2, NULL) == NULL); // EXPECT_TRUE(db.GetURLInfo(url2, NULL) == NULL);
......
...@@ -130,12 +130,12 @@ class TokenServiceTest : public testing::Test { ...@@ -130,12 +130,12 @@ class TokenServiceTest : public testing::Test {
TEST_F(TokenServiceTest, SanityCheck) { TEST_F(TokenServiceTest, SanityCheck) {
EXPECT_TRUE(service_.HasLsid()); EXPECT_TRUE(service_.HasLsid());
EXPECT_EQ(service_.GetLsid(), "lsid"); EXPECT_EQ(service_.GetLsid(), "lsid");
EXPECT_FALSE(service_.HasTokenForService("nonexistant service")); EXPECT_FALSE(service_.HasTokenForService("nonexistent service"));
} }
TEST_F(TokenServiceTest, NoToken) { TEST_F(TokenServiceTest, NoToken) {
EXPECT_FALSE(service_.HasTokenForService("nonexistant service")); EXPECT_FALSE(service_.HasTokenForService("nonexistent service"));
EXPECT_EQ(service_.GetTokenForService("nonexistant service"), std::string()); EXPECT_EQ(service_.GetTokenForService("nonexistent service"), std::string());
} }
TEST_F(TokenServiceTest, NotificationSuccess) { TEST_F(TokenServiceTest, NotificationSuccess) {
......
...@@ -392,7 +392,7 @@ void Predictor::GetHtmlInfo(std::string* output) { ...@@ -392,7 +392,7 @@ void Predictor::GetHtmlInfo(std::string* output) {
// Partition the UrlInfo's into categories. // Partition the UrlInfo's into categories.
for (SortedUrlInfo::iterator it(snapshot.begin()); for (SortedUrlInfo::iterator it(snapshot.begin());
it != snapshot.end(); it++) { it != snapshot.end(); it++) {
if (it->second.was_nonexistant()) { if (it->second.was_nonexistent()) {
name_not_found.push_back(it->second); name_not_found.push_back(it->second);
continue; continue;
} }
......
// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -110,7 +110,7 @@ class UrlInfo { ...@@ -110,7 +110,7 @@ class UrlInfo {
} }
bool was_found() const { return FOUND == state_; } bool was_found() const { return FOUND == state_; }
bool was_nonexistant() const { return NO_SUCH_NAME == state_; } bool was_nonexistent() const { return NO_SUCH_NAME == state_; }
bool is_assigned() const { bool is_assigned() const {
return ASSIGNED == state_ || ASSIGNED_BUT_MARKED == state_; return ASSIGNED == state_ || ASSIGNED_BUT_MARKED == state_;
} }
......
// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -106,7 +106,7 @@ TEST(DnsHostInfoTest, CongestionResetStateTest) { ...@@ -106,7 +106,7 @@ TEST(DnsHostInfoTest, CongestionResetStateTest) {
// Since this was a new info instance, and it never got resolved, we land back // Since this was a new info instance, and it never got resolved, we land back
// in a PENDING state rather than FOUND or NO_SUCH_NAME. // in a PENDING state rather than FOUND or NO_SUCH_NAME.
EXPECT_FALSE(info.was_found()); EXPECT_FALSE(info.was_found());
EXPECT_FALSE(info.was_nonexistant()); EXPECT_FALSE(info.was_nonexistent());
// Make sure we're completely re-usable, by going throug a normal flow. // Make sure we're completely re-usable, by going throug a normal flow.
info.SetQueuedState(UrlInfo::UNIT_TEST_MOTIVATED); info.SetQueuedState(UrlInfo::UNIT_TEST_MOTIVATED);
......
// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -70,7 +70,7 @@ void WebDataService::CancelRequest(Handle h) { ...@@ -70,7 +70,7 @@ void WebDataService::CancelRequest(Handle h) {
AutoLock l(pending_lock_); AutoLock l(pending_lock_);
RequestMap::iterator i = pending_requests_.find(h); RequestMap::iterator i = pending_requests_.find(h);
if (i == pending_requests_.end()) { if (i == pending_requests_.end()) {
NOTREACHED() << "Canceling a nonexistant web data service request"; NOTREACHED() << "Canceling a nonexistent web data service request";
return; return;
} }
i->second->Cancel(); i->second->Cancel();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment