Roll src/net/third_party/quiche/src/ 4080a8597..8da8f7162 (21 commits) and sync flags.

    https://quiche.googlesource.com/quiche.git/+log/4080a859725c..8da8f7162b76

    $ git log 4080a8597..8da8f7162 --date=short --no-merges --format='%ad %ae %s'
    2019-06-25 bnc Add static_cast<uint8_t> in HpackVarintEncoderTest.
    2019-06-25 bnc Add helpers and use StringPiece in HttpDecoderTest.
    2019-06-24 bnc Implement QuicStreamSequencerBuffer::PeekRegion().
    2019-06-24 bnc Remove test-only HttpDecoder::current_frame_type() accessor.
    2019-06-24 nharper Remove CreateSslCtx argument from QUIC crypto config constructors
    2019-06-24 bnc Do not handle impossible outcomes in HttpDecoder.
    2019-06-24 renjietang Avoid performing pending stream actions after the connection is closed.
    2019-06-24 bnc Clean up HpackVarintEncoder internals.
    2019-06-24 fayang gfe-relnote: In QUIC, replace member variables current* with on stack struct ReceivedPacketInfo in QuicDispatcher. Refactor only, not protected.
    2019-06-24 bnc Clean up HpackVarintEncoder interface.
    2019-06-24 bnc Clean up QpackInstructionEncoder internals.
    2019-06-24 bnc Introduce IovecToStringPiece() in QuicStreamSequencerBufferTest.
    2019-06-24 bnc Add |written_| member to QuicStreamSequencerBufferTest.
    2019-06-24 bnc Clean up PrefetchNextRegion.
    2019-06-24 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_terminate_gquic_connection_as_ietf.
    2019-06-24 fkastenholz Alter QuicConnectionDebugVisitor::OnConnectionClosed to take QuicConnectionCloseFrame
    2019-06-21 bnc Modify QpackInstructionEncoder API.
    2019-06-21 dschinazi Ignore C++ warnings in auto-generated proto headers
    2019-06-21 quiche-dev Add test to ensure that a push promise on a data stream closes the connection.
    2019-06-21 quiche-dev Add test to ensure that a push promise on a control stream closes the connection.
    2019-06-21 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_tolerate_reneging.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ic732cdbc8e428e3ba45b71ab9f38d7ddf16b8c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673581
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672209}

DEPS

@@ -277,7 +277,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling feed
   # and whatever else without interference from each other.
-  'quiche_revision': '4080a859725c90354baefc8ad3743e2bf5cb7280',
+  'quiche_revision': '8da8f7162b76a63aa5d3c2062d12f872f9dc1dac',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ios_webkit
   # and whatever else without interference from each other.

net/quic/quic_chromium_client_session.cc

@@ -1591,9 +1591,11 @@ void QuicChromiumClientSession::OnConnectionClosed(
     const quic::QuicConnectionCloseFrame& frame,
     quic::ConnectionCloseSource source) {
   DCHECK(!connection()->connected());
+
+  logger_->OnConnectionClosed(frame, source);
+
   const quic::QuicErrorCode error = frame.quic_error_code;
   const std::string& error_details = frame.error_details;
-  logger_->OnConnectionClosed(error, error_details, source);
 
   RecordConnectionCloseErrorCode(error, source, session_key_.host(),
                                  IsCryptoHandshakeConfirmed());

net/quic/quic_connection_logger.cc

@@ -797,14 +797,14 @@ void QuicConnectionLogger::OnCryptoHandshakeMessageSent(
 }
 
 void QuicConnectionLogger::OnConnectionClosed(
-    quic::QuicErrorCode error,
-    const string& error_details,
+    const quic::QuicConnectionCloseFrame& frame,
     quic::ConnectionCloseSource source) {
   if (!net_log_is_capturing_)
     return;
-  net_log_.AddEvent(NetLogEventType::QUIC_SESSION_CLOSED,
-                    base::Bind(&NetLogQuicOnConnectionClosedCallback, error,
-                               error_details, source));
+  net_log_.AddEvent(
+      NetLogEventType::QUIC_SESSION_CLOSED,
+      base::Bind(&NetLogQuicOnConnectionClosedCallback, frame.quic_error_code,
+                 frame.error_details, source));
 }
 
 void QuicConnectionLogger::OnSuccessfulVersionNegotiation(

net/quic/quic_connection_logger.h

@@ -82,8 +82,7 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
   void OnPublicResetPacket(const quic::QuicPublicResetPacket& packet) override;
   void OnVersionNegotiationPacket(
       const quic::QuicVersionNegotiationPacket& packet) override;
-  void OnConnectionClosed(quic::QuicErrorCode error,
-                          const std::string& error_details,
+  void OnConnectionClosed(const quic::QuicConnectionCloseFrame& frame,
                           quic::ConnectionCloseSource source) override;
   void OnSuccessfulVersionNegotiation(
       const quic::ParsedQuicVersion& version) override;

net/quic/quic_flags_list.h

@@ -205,10 +205,6 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_47, false)
 // If true, disable QUIC version 39.
 QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_39, false)
 
-// In QUIC, do not close connection if received an in-order ACK with decreased
-// largest_acked.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_tolerate_reneging, true)
-
 // If true and using Leto for QUIC shared-key calculations, GFE will react to a
 // failure to contact Leto by sending a REJ containing a fallback ServerConfig,
 // allowing the client to continue the handshake.
@@ -223,11 +219,6 @@ QUIC_FLAG(bool,
           FLAGS_quic_restart_flag_dont_fetch_quic_private_keys_from_leto,
           false)
 
-// If true, terminate Google QUIC connections similary as IETF QUIC.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_terminate_gquic_connection_as_ietf,
-          true)
-
 // In v44 and above, where STOP_WAITING is never sent, close the connection if
 // it's received.
 QUIC_FLAG(bool,
@@ -275,7 +266,7 @@ QUIC_FLAG(bool,
           false)
 
 // If true, disable QUIC version 44.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_44, false)
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_44, true)
 
 // If true, ignore TLPR if there is no pending stream data.
 QUIC_FLAG(bool,
@@ -283,7 +274,7 @@ QUIC_FLAG(bool,
           true)
 // If true, when detecting losses, use packets_acked of corresponding packet
 // number space.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_packets_acked, false)
+QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_packets_acked, true)
 
 // QUIC version 99 will use this stream ID for the headers stream.
 QUIC_FLAG(int64_t, FLAGS_quic_headers_stream_id_in_v99, 0)