Commit e81f1428 authored by Carlos Caballero's avatar Carlos Caballero Committed by Commit Bot

Remove references of MessageLoopForIO in /storage/browser/fileapi

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Change-Id: I57789b7eb07a5d297bcaef61c979a113252acb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733615
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683901}
parent 8c755bb0
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "base/files/scoped_temp_dir.h" #include "base/files/scoped_temp_dir.h"
#include "base/location.h" #include "base/location.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "base/stl_util.h" #include "base/stl_util.h"
...@@ -738,7 +737,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper) { ...@@ -738,7 +737,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper) {
base::WriteFile(source_path, kTestData, base::WriteFile(source_path, kTestData,
base::size(kTestData) - 1); // Exclude trailing '\0'. base::size(kTestData) - 1); // Exclude trailing '\0'.
base::MessageLoopForIO message_loop; base::test::ScopedTaskEnvironment scoped_task_environment(
base::test::ScopedTaskEnvironment::MainThreadType::IO);
base::Thread file_thread("file_thread"); base::Thread file_thread("file_thread");
ASSERT_TRUE(file_thread.Start()); ASSERT_TRUE(file_thread.Start());
ScopedThreadStopper thread_stopper(&file_thread); ScopedThreadStopper thread_stopper(&file_thread);
...@@ -795,7 +795,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelperWithFlush) { ...@@ -795,7 +795,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelperWithFlush) {
base::WriteFile(source_path, kTestData, base::WriteFile(source_path, kTestData,
base::size(kTestData) - 1); // Exclude trailing '\0'. base::size(kTestData) - 1); // Exclude trailing '\0'.
base::MessageLoopForIO message_loop; base::test::ScopedTaskEnvironment scoped_task_environment(
base::test::ScopedTaskEnvironment::MainThreadType::IO);
base::Thread file_thread("file_thread"); base::Thread file_thread("file_thread");
ASSERT_TRUE(file_thread.Start()); ASSERT_TRUE(file_thread.Start());
ScopedThreadStopper thread_stopper(&file_thread); ScopedThreadStopper thread_stopper(&file_thread);
...@@ -848,7 +849,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper_Cancel) { ...@@ -848,7 +849,8 @@ TEST(LocalFileSystemCopyOrMoveOperationTest, StreamCopyHelper_Cancel) {
base::WriteFile(source_path, kTestData, base::WriteFile(source_path, kTestData,
base::size(kTestData) - 1); // Exclude trailing '\0'. base::size(kTestData) - 1); // Exclude trailing '\0'.
base::MessageLoopForIO message_loop; base::test::ScopedTaskEnvironment scoped_task_environment(
base::test::ScopedTaskEnvironment::MainThreadType::IO);
base::Thread file_thread("file_thread"); base::Thread file_thread("file_thread");
ASSERT_TRUE(file_thread.Start()); ASSERT_TRUE(file_thread.Start());
ScopedThreadStopper thread_stopper(&file_thread); ScopedThreadStopper thread_stopper(&file_thread);
......
...@@ -16,8 +16,8 @@ ...@@ -16,8 +16,8 @@
#include "base/files/scoped_temp_dir.h" #include "base/files/scoped_temp_dir.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/test/scoped_task_environment.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "components/services/filesystem/public/mojom/types.mojom.h" #include "components/services/filesystem/public/mojom/types.mojom.h"
...@@ -281,7 +281,8 @@ class DraggedFileUtilTest : public testing::Test { ...@@ -281,7 +281,8 @@ class DraggedFileUtilTest : public testing::Test {
base::ScopedTempDir data_dir_; base::ScopedTempDir data_dir_;
base::ScopedTempDir partition_dir_; base::ScopedTempDir partition_dir_;
base::MessageLoopForIO message_loop_; base::test::ScopedTaskEnvironment scoped_task_environment_{
base::test::ScopedTaskEnvironment::MainThreadType::IO};
std::string filesystem_id_; std::string filesystem_id_;
scoped_refptr<FileSystemContext> file_system_context_; scoped_refptr<FileSystemContext> file_system_context_;
std::map<base::FilePath, base::FilePath> toplevel_root_map_; std::map<base::FilePath, base::FilePath> toplevel_root_map_;
......
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/files/scoped_temp_dir.h" #include "base/files/scoped_temp_dir.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/test/scoped_task_environment.h"
#include "net/base/io_buffer.h" #include "net/base/io_buffer.h"
#include "net/base/net_errors.h" #include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h" #include "net/base/test_completion_callback.h"
...@@ -116,7 +116,8 @@ class FileSystemFileStreamReaderTest : public testing::Test { ...@@ -116,7 +116,8 @@ class FileSystemFileStreamReaderTest : public testing::Test {
base::FilePath().AppendASCII(file_name)); base::FilePath().AppendASCII(file_name));
} }
base::MessageLoopForIO message_loop_; base::test::ScopedTaskEnvironment scoped_task_environment_{
base::test::ScopedTaskEnvironment::MainThreadType::IO};
base::ScopedTempDir temp_dir_; base::ScopedTempDir temp_dir_;
scoped_refptr<FileSystemContext> file_system_context_; scoped_refptr<FileSystemContext> file_system_context_;
base::Time test_file_modification_time_; base::Time test_file_modification_time_;
......
...@@ -18,10 +18,10 @@ ...@@ -18,10 +18,10 @@
#include "base/files/scoped_temp_dir.h" #include "base/files/scoped_temp_dir.h"
#include "base/location.h" #include "base/location.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/test/scoped_task_environment.h"
#include "base/threading/thread.h" #include "base/threading/thread.h"
#include "net/base/io_buffer.h" #include "net/base/io_buffer.h"
#include "net/base/net_errors.h" #include "net/base/net_errors.h"
...@@ -105,7 +105,8 @@ class LocalFileStreamReaderTest : public testing::Test { ...@@ -105,7 +105,8 @@ class LocalFileStreamReaderTest : public testing::Test {
} }
private: private:
base::MessageLoopForIO message_loop_; base::test::ScopedTaskEnvironment scoped_task_environment_{
base::test::ScopedTaskEnvironment::MainThreadType::IO};
base::Thread file_thread_; base::Thread file_thread_;
base::ScopedTempDir dir_; base::ScopedTempDir dir_;
base::Time test_file_modification_time_; base::Time test_file_modification_time_;
......
...@@ -14,9 +14,9 @@ ...@@ -14,9 +14,9 @@
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h" #include "base/files/scoped_temp_dir.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "base/test/scoped_task_environment.h"
#include "base/threading/thread.h" #include "base/threading/thread.h"
#include "net/base/io_buffer.h" #include "net/base/io_buffer.h"
#include "net/base/test_completion_callback.h" #include "net/base/test_completion_callback.h"
...@@ -73,7 +73,8 @@ class LocalFileStreamWriterTest : public testing::Test { ...@@ -73,7 +73,8 @@ class LocalFileStreamWriterTest : public testing::Test {
} }
private: private:
base::MessageLoopForIO message_loop_; base::test::ScopedTaskEnvironment scoped_task_environment_{
base::test::ScopedTaskEnvironment::MainThreadType::IO};
base::Thread file_thread_; base::Thread file_thread_;
base::ScopedTempDir temp_dir_; base::ScopedTempDir temp_dir_;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment