Skip to content

GitLab

T
tangled
Commit e826ee95 authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot
Browse files
Options

RC: Compress all chrome://discards resources. 

I don't know whether to trust these numbers, but this is what I see
for my local Windows release 32 bit build.

Uncompressed:
3,034,139 browser_resources.pak
233,038,336 mini_installer.exe

Compressed:
2,869,382 browser_resources.pak
232,873,472 mini_installer.exe

Bug: 891310
Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
Reviewed-on: https://chromium-review.googlesource.com/c/1327406Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606833}
parent 9a6d7fa9
Hide whitespace changes
Inline Side-by-side
Showing with 18 additions and 17 deletions
chrome/browser/browser_resources.grd
View file @ e826ee95
...@@ -71,23 +71,23 @@ ...@@ -71,23 +71,23 @@
</structures> </structures>
<includes> <includes>
<if expr="is_win or is_macosx or desktop_linux or chromeos"> <if expr="is_win or is_macosx or desktop_linux or chromeos">
<include name="IDR_DISCARDS_MOJO_API_HTML" file="resources\discards\mojo_api.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_MOJO_API_HTML" file="resources\discards\mojo_api.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_DATABASE_TAB_HTML" file="resources\discards\database_tab.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_DATABASE_TAB_HTML" file="resources\discards\database_tab.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_DATABASE_TAB_JS" file="resources\discards\database_tab.js" type="BINDATA" /> <include name="IDR_DISCARDS_DATABASE_TAB_JS" file="resources\discards\database_tab.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_DISCARDS_MAIN_HTML" file="resources\discards\discards_main.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_DISCARDS_MAIN_HTML" file="resources\discards\discards_main.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_DISCARDS_MAIN_JS" file="resources\discards\discards_main.js" type="BINDATA" /> <include name="IDR_DISCARDS_DISCARDS_MAIN_JS" file="resources\discards\discards_main.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_DISCARDS_TAB_HTML" file="resources\discards\discards_tab.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_DISCARDS_TAB_HTML" file="resources\discards\discards_tab.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_DISCARDS_TAB_JS" file="resources\discards\discards_tab.js" type="BINDATA" /> <include name="IDR_DISCARDS_DISCARDS_TAB_JS" file="resources\discards\discards_tab.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_GRAPH_TAB_HTML" file="${root_gen_dir}\chrome\browser\resources\discards\graph_tab.html" use_base_dir="false" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_GRAPH_TAB_HTML" file="${root_gen_dir}\chrome\browser\resources\discards\graph_tab.html" compress="gzip" use_base_dir="false" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_GRAPH_TAB_JS" file="resources\discards\graph_tab.js" type="BINDATA" /> <include name="IDR_DISCARDS_GRAPH_TAB_JS" file="resources\discards\graph_tab.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_HTML" file="resources\discards\discards.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_HTML" file="resources\discards\discards.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_JS" file="resources\discards\discards.js" type="BINDATA" /> <include name="IDR_DISCARDS_JS" file="resources\discards\discards.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_LIFECYCLE_UNIT_STATE_MOJO_JS" file="${root_gen_dir}\chrome\browser\resource_coordinator\lifecycle_unit_state.mojom.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DISCARDS_LIFECYCLE_UNIT_STATE_MOJO_JS" file="${root_gen_dir}\chrome\browser\resource_coordinator\lifecycle_unit_state.mojom.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_DISCARDS_MOJO_JS" file="${root_gen_dir}\chrome\browser\ui\webui\discards\discards.mojom.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DISCARDS_MOJO_JS" file="${root_gen_dir}\chrome\browser\ui\webui\discards\discards.mojom.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_DISCARDS_MOJO_PUBLIC_BASE_PROCESS_ID_MOJOM_JS" file="${root_gen_dir}\mojo\public\mojom\base\process_id.mojom.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DISCARDS_MOJO_PUBLIC_BASE_PROCESS_ID_MOJOM_JS" file="${root_gen_dir}\mojo\public\mojom\base\process_id.mojom.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_DISCARDS_SORTED_TABLE_BEHAVIOR_HTML" file="resources\discards\sorted_table_behavior.html" allowexternalscript="true" type="BINDATA" /> <include name="IDR_DISCARDS_SORTED_TABLE_BEHAVIOR_HTML" file="resources\discards\sorted_table_behavior.html" compress="gzip" allowexternalscript="true" type="BINDATA" />
<include name="IDR_DISCARDS_SORTED_TABLE_BEHAVIOR_JS" file="resources\discards\sorted_table_behavior.js" type="BINDATA" /> <include name="IDR_DISCARDS_SORTED_TABLE_BEHAVIOR_JS" file="resources\discards\sorted_table_behavior.js" compress="gzip" type="BINDATA" />
<include name="IDR_DISCARDS_WEBUI_GRAPH_DUMP_MOJO_JS" file="${root_gen_dir}\services\resource_coordinator\public\mojom\webui_graph_dump.mojom.js" use_base_dir="false" type="BINDATA" /> <include name="IDR_DISCARDS_WEBUI_GRAPH_DUMP_MOJO_JS" file="${root_gen_dir}\services\resource_coordinator\public\mojom\webui_graph_dump.mojom.js" compress="gzip" use_base_dir="false" type="BINDATA" />
</if> </if>
<if expr="is_win"> <if expr="is_win">
<include name="IDR_ABOUT_CONFLICTS_HTML" file="resources\conflicts\about_conflicts.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" /> <include name="IDR_ABOUT_CONFLICTS_HTML" file="resources\conflicts\about_conflicts.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />
......
chrome/browser/ui/webui/discards/discards_ui.cc
View file @ e826ee95
...@@ -426,6 +426,7 @@ DiscardsUI::DiscardsUI(content::WebUI* web_ui) ...@@ -426,6 +426,7 @@ DiscardsUI::DiscardsUI(content::WebUI* web_ui)
IDR_DISCARDS_MOJO_PUBLIC_BASE_PROCESS_ID_MOJOM_JS); IDR_DISCARDS_MOJO_PUBLIC_BASE_PROCESS_ID_MOJOM_JS);
source->SetDefaultResource(IDR_DISCARDS_HTML); source->SetDefaultResource(IDR_DISCARDS_HTML);
source->UseGzip();
Profile* profile = Profile::FromWebUI(web_ui); Profile* profile = Profile::FromWebUI(web_ui);
content::WebUIDataSource::Add(profile, source.release()); content::WebUIDataSource::Add(profile, source.release());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment