Commit e83529e2 authored by Robert Sesek's avatar Robert Sesek Committed by Commit Bot

apple: Convert GN libs lists to frameworks in //components.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: I6a0e4f1c679d72cb799374dc1e20b93a71b872cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277975
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784482}
parent 94a42a3b
......@@ -88,7 +88,7 @@ static_library("browser") {
"bookmark_pasteboard_helper_mac.h",
"bookmark_pasteboard_helper_mac.mm",
]
libs = [
frameworks = [
"AppKit.framework",
"Foundation.framework",
]
......
......@@ -150,7 +150,7 @@ if (is_mac || is_ios) {
deps += [ "//components/gwp_asan/client" ]
}
libs = [ "Foundation.framework" ]
frameworks = [ "Foundation.framework" ]
}
}
......
......@@ -156,7 +156,7 @@ jumbo_static_library("metrics") {
}
if (is_mac) {
libs = [
frameworks = [
# The below are all needed for drive_metrics_provider_mac.mm.
"CoreFoundation.framework",
"DiskArbitration.framework",
......
......@@ -66,7 +66,7 @@ component("app_shim") {
"//ui/gfx",
"//ui/strings:ui_strings_grit",
]
libs = [
frameworks = [
"Cocoa.framework",
"QuartzCore.framework",
]
......
......@@ -24,5 +24,5 @@ component("browser") {
"//mojo/public/cpp/bindings:bindings",
"//ui/gfx",
]
libs = [ "Cocoa.framework" ]
frameworks = [ "Cocoa.framework" ]
}
......@@ -32,7 +32,7 @@ static_library("quarantine") {
}
if (is_mac) {
libs = [
frameworks = [
"Carbon.framework",
"Foundation.framework",
]
......@@ -55,7 +55,7 @@ source_set("common") {
]
if (is_mac) {
libs = [
frameworks = [
"Carbon.framework",
"Foundation.framework",
]
......@@ -80,7 +80,7 @@ source_set("test_support") {
]
if (is_mac) {
libs = [
frameworks = [
"Carbon.framework",
"Foundation.framework",
]
......@@ -123,7 +123,7 @@ source_set("unit_tests") {
}
if (is_mac) {
libs = [
frameworks = [
"Carbon.framework",
"Foundation.framework",
]
......
......@@ -45,7 +45,7 @@ static_library("storage_monitor") {
"storage_monitor_mac.h",
"storage_monitor_mac.mm",
]
libs = [
frameworks = [
"DiskArbitration.framework",
"Foundation.framework",
"ImageCaptureCore.framework",
......
......@@ -54,7 +54,7 @@ jumbo_static_library("sync_device_info") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]
if (is_mac) {
libs = [
frameworks = [
"CoreFoundation.framework",
"SystemConfiguration.framework", # For local_device_info_util_mac.mm.
]
......
......@@ -32,7 +32,7 @@ executable("top_domain_generator") {
"//url:url",
]
if (is_ios) {
libs = [ "UIKit.framework" ]
frameworks = [ "UIKit.framework" ]
}
}
......@@ -74,7 +74,7 @@ executable("make_top_domain_list_variables") {
"//third_party/icu",
]
if (is_ios) {
libs = [ "UIKit.framework" ]
frameworks = [ "UIKit.framework" ]
}
}
......
......@@ -69,7 +69,7 @@ if (is_mac) {
"//ui/gl",
]
libs = [
frameworks = [
"Metal.framework",
"Foundation.framework",
]
......
......@@ -243,7 +243,7 @@ viz_component("service") {
]
deps += [ "//ui/accelerated_widget_mac" ]
libs = [ "IOSurface.framework" ]
frameworks = [ "IOSurface.framework" ]
}
if (is_android || use_ozone) {
......@@ -545,7 +545,7 @@ viz_source_set("unit_tests") {
"display/overlay_ca_unittest.cc",
"display_embedder/software_output_device_mac_unittest.mm",
]
libs = [ "IOSurface.framework" ]
frameworks = [ "IOSurface.framework" ]
}
if (is_win) {
......
......@@ -32,7 +32,7 @@ jumbo_component("wifi") {
}
if (is_mac) {
libs = [
frameworks = [
"CoreWLAN.framework",
"Foundation.framework",
"SystemConfiguration.framework",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment