Commit e841d062 authored by shalev@chromium.org's avatar shalev@chromium.org

Bug fix for lack of errors on requests with invalid ports

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Review URL: https://chromiumcodereview.appspot.com/10834053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148925 0039d316-1c4b-4281-b951-d872f2087c98
parent 28c889e4
...@@ -5,7 +5,12 @@ ...@@ -5,7 +5,12 @@
#include "net/url_request/ftp_protocol_handler.h" #include "net/url_request/ftp_protocol_handler.h"
#include "base/logging.h" #include "base/logging.h"
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_error_job.h"
#include "net/url_request/url_request_ftp_job.h" #include "net/url_request/url_request_ftp_job.h"
#include "googleurl/src/gurl.h"
namespace net { namespace net {
...@@ -22,6 +27,12 @@ FtpProtocolHandler::FtpProtocolHandler( ...@@ -22,6 +27,12 @@ FtpProtocolHandler::FtpProtocolHandler(
URLRequestJob* FtpProtocolHandler::MaybeCreateJob( URLRequestJob* FtpProtocolHandler::MaybeCreateJob(
URLRequest* request) const { URLRequest* request) const {
int port = request->url().IntPort();
if (request->url().has_port() &&
!IsPortAllowedByFtp(port) && !IsPortAllowedByOverride(port)) {
return new URLRequestErrorJob(request, ERR_UNSAFE_PORT);
}
return new URLRequestFtpJob(request, return new URLRequestFtpJob(request,
network_delegate_, network_delegate_,
ftp_transaction_factory_, ftp_transaction_factory_,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment