Remove old profile startup metrics.

Bug: 969926
Change-Id: I6dfab44d9edf50c29c32e2b32da8d3ed6c597a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709784Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681447}

chrome/browser/prefs/browser_prefs.cc

@@ -6,7 +6,6 @@
 
 #include <string>
 
-#include "base/metrics/histogram_macros.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "chrome/browser/about_flags.h"
@@ -694,7 +693,6 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry,
                           const std::string& locale) {
   TRACE_EVENT0("browser", "chrome::RegisterProfilePrefs");
-  SCOPED_UMA_HISTOGRAM_TIMER("Settings.RegisterProfilePrefsTime");
   // User prefs. Please keep this list alphabetized.
   AccessibilityLabelsService::RegisterProfilePrefs(registry);
   AccessibilityUIMessageHandler::RegisterProfilePrefs(registry);

chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -432,7 +432,6 @@ std::unique_ptr<sync_preferences::PrefServiceSyncable> CreateProfilePrefs(
     scoped_refptr<base::SequencedTaskRunner> io_task_runner,
     std::unique_ptr<PrefValueStore::Delegate> delegate) {
   TRACE_EVENT0("browser", "chrome_prefs::CreateProfilePrefs");
-  SCOPED_UMA_HISTOGRAM_TIMER("PrefService.CreateProfilePrefsTime");
 
   prefs::mojom::ResetOnLoadObserverPtr reset_on_load_observer;
   mojo::MakeStrongBinding(

chrome/browser/profiles/profile_impl.cc

@@ -22,7 +22,6 @@
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
-#include "base/metrics/histogram_macros.h"
 #include "base/path_service.h"
 #include "base/sequenced_task_runner.h"
 #include "base/strings/string_number_conversions.h"
@@ -629,7 +628,6 @@ void ProfileImpl::LoadPrefsForNormalStartup(bool async_prefs) {
 
 void ProfileImpl::DoFinalInit() {
   TRACE_EVENT0("browser", "ProfileImpl::DoFinalInit")
-  SCOPED_UMA_HISTOGRAM_TIMER("Profile.ProfileImplDoFinalInit");
 
   PrefService* prefs = GetPrefs();
   pref_change_registrar_.Init(prefs);
@@ -756,12 +754,9 @@ void ProfileImpl::DoFinalInit() {
   // initialized.
   SharingServiceFactory::GetForBrowserContext(this);
 
-  {
-    SCOPED_UMA_HISTOGRAM_TIMER("Profile.NotifyProfileCreatedTime");
-    content::NotificationService::current()->Notify(
-        chrome::NOTIFICATION_PROFILE_CREATED, content::Source<Profile>(this),
-        content::NotificationService::NoDetails());
-  }
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_PROFILE_CREATED, content::Source<Profile>(this),
+      content::NotificationService::NoDetails());
 }
 
 base::FilePath ProfileImpl::last_selected_directory() {
@@ -947,7 +942,6 @@ ExtensionSpecialStoragePolicy* ProfileImpl::GetExtensionSpecialStoragePolicy() {
 
 void ProfileImpl::OnLocaleReady() {
   TRACE_EVENT0("browser", "ProfileImpl::OnLocaleReady");
-  SCOPED_UMA_HISTOGRAM_TIMER("Profile.OnLocaleReadyTime");
   // Migrate obsolete prefs.
   if (g_browser_process->local_state())
     MigrateObsoleteBrowserPrefs(this, g_browser_process->local_state());
@@ -985,11 +979,8 @@ void ProfileImpl::OnLocaleReady() {
 
   FullBrowserTransitionManager::Get()->OnProfileCreated(this);
 
-  {
-    SCOPED_UMA_HISTOGRAM_TIMER("Profile.CreateBrowserContextServicesTime");
-    BrowserContextDependencyManager::GetInstance()
-        ->CreateBrowserContextServices(this);
-  }
+  BrowserContextDependencyManager::GetInstance()->CreateBrowserContextServices(
+      this);
 
   ChromeVersionService::OnProfileLoaded(prefs_.get(), IsNewProfile());
   DoFinalInit();

chrome/browser/profiles/profile_manager.cc

@@ -1314,7 +1314,6 @@ void ProfileManager::DoFinalInitLogging(Profile* profile) {
 
 Profile* ProfileManager::CreateProfileHelper(const base::FilePath& path) {
   TRACE_EVENT0("browser", "ProfileManager::CreateProfileHelper");
-  SCOPED_UMA_HISTOGRAM_TIMER("Profile.CreateProfileHelperTime");
 
   return Profile::CreateProfile(path, NULL, Profile::CREATE_MODE_SYNCHRONOUS)
       .release();
@@ -1396,7 +1395,6 @@ bool ProfileManager::AddProfile(std::unique_ptr<Profile> profile) {
 Profile* ProfileManager::CreateAndInitializeProfile(
     const base::FilePath& profile_dir) {
   TRACE_EVENT0("browser", "ProfileManager::CreateAndInitializeProfile");
-  SCOPED_UMA_HISTOGRAM_LONG_TIMER("Profile.CreateAndInitializeProfile");
 
   // CHECK that we are not trying to load the same profile twice, to prevent
   // profile corruption. Note that this check also covers the case when we have

tools/metrics/histograms/histograms.xml

@@ -104144,6 +104144,9 @@ uploading your change for review.
 </histogram>
 
 <histogram name="PrefService.CreateProfilePrefsTime" units="ms">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>The amount of time that elapsed during CreateProfilePrefs.</summary>
 </histogram>
@@ -106757,11 +106760,17 @@ uploading your change for review.
 
 <histogram name="Profile.CreateAndInitializeProfile" units="ms"
     expires_after="M77">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>Length of time to setup profile.</summary>
 </histogram>
 
 <histogram name="Profile.CreateBrowserContextServicesTime" units="ms">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during the CreateBrowserContextServices call
@@ -106771,6 +106780,9 @@ uploading your change for review.
 
 <histogram name="Profile.CreateProfileHelperTime" units="ms"
     expires_after="M77">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during ProfileManager::CreateProfileHelper.
@@ -107004,6 +107016,9 @@ uploading your change for review.
 
 <histogram name="Profile.NotifyProfileCreatedTime" units="ms"
     expires_after="M77">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during the Notify() of
@@ -107158,6 +107173,9 @@ uploading your change for review.
 </histogram>
 
 <histogram name="Profile.OnLocaleReadyTime" units="ms">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during ProfileImpl::OnLocaleReady. This
@@ -107215,6 +107233,9 @@ uploading your change for review.
 </histogram>
 
 <histogram name="Profile.ProfileImplDoFinalInit" units="ms">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during the ProfileImpl::DoFinalInit().
@@ -124430,6 +124451,9 @@ should be kept until we remove incident reporting. -->
 </histogram>
 
 <histogram name="Settings.RegisterProfilePrefsTime" units="ms">
+  <obsolete>
+    Removed 07/2019.
+  </obsolete>
   <owner>rkaplow@chromium.org</owner>
   <summary>
     The amount of time that elapsed during RegisterProfilePrefs.