Commit e84fbe91 authored by Regan Hsu's avatar Regan Hsu Committed by Commit Bot

[CrOS OSSettings] Re-enable skipping of os browsertests tests in debug.

Bug: 1013094
Change-Id: I27d3fd476d3c747ac7eb7a90eb179c3b787baec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852420Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704906}
parent 7e556393
...@@ -13,7 +13,7 @@ GEN_INCLUDE(['//chrome/test/data/webui/polymer_browser_test_base.js']); ...@@ -13,7 +13,7 @@ GEN_INCLUDE(['//chrome/test/data/webui/polymer_browser_test_base.js']);
// Only run in release builds because we frequently see test timeouts in debug. // Only run in release builds because we frequently see test timeouts in debug.
// We suspect this is because the settings page loads slowly in debug. // We suspect this is because the settings page loads slowly in debug.
// https://crbug.com/1003483 // https://crbug.com/1003483
// GEN('#if defined(NDEBUG)'); GEN('#if defined(NDEBUG)');
GEN('#include "ash/public/cpp/ash_features.h"'); GEN('#include "ash/public/cpp/ash_features.h"');
GEN('#include "build/branding_buildflags.h"'); GEN('#include "build/branding_buildflags.h"');
...@@ -112,8 +112,7 @@ var OSSettingsPageTest = class extends OSSettingsBrowserTest { ...@@ -112,8 +112,7 @@ var OSSettingsPageTest = class extends OSSettingsBrowserTest {
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsPageTest', 'AllJsTests', () => {
TEST_F('OSSettingsPageTest', 'DISABLED_AllJsTests', () => {
// Run all registered tests. // Run all registered tests.
mocha.run(); mocha.run();
}); });
...@@ -189,8 +188,7 @@ var OSSettingsAppManagementDomSwitchTest = ...@@ -189,8 +188,7 @@ var OSSettingsAppManagementDomSwitchTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementDomSwitchTest', 'All', function() {
TEST_F('OSSettingsAppManagementDomSwitchTest', 'DISABLED_All', function() {
mocha.run(); mocha.run();
}); });
...@@ -211,8 +209,7 @@ var OSSettingsAppManagementPageTest = ...@@ -211,8 +209,7 @@ var OSSettingsAppManagementPageTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementPageTest', 'AllJsTests', () => {
TEST_F('OSSettingsAppManagementPageTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -233,12 +230,9 @@ var OSSettingsAppManagementPwaPermissionViewTest = ...@@ -233,12 +230,9 @@ var OSSettingsAppManagementPwaPermissionViewTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementPwaPermissionViewTest', 'AllJsTests', () => {
TEST_F( mocha.run();
'OSSettingsAppManagementPwaPermissionViewTest', 'DISABLED_AllJsTests', });
() => {
mocha.run();
});
// Test fixture for the app management arc permission view element. // Test fixture for the app management arc permission view element.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
...@@ -257,12 +251,9 @@ var OSSettingsAppManagementArcPermissionViewTest = ...@@ -257,12 +251,9 @@ var OSSettingsAppManagementArcPermissionViewTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementArcPermissionViewTest', 'AllJsTests', () => {
TEST_F( mocha.run();
'OSSettingsAppManagementArcPermissionViewTest', 'DISABLED_AllJsTests', });
() => {
mocha.run();
});
// Test fixture for the app management managed app view. // Test fixture for the app management managed app view.
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
...@@ -281,8 +272,7 @@ var OSSettingsAppManagementManagedAppTest = ...@@ -281,8 +272,7 @@ var OSSettingsAppManagementManagedAppTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementManagedAppTest', 'AllJsTests', () => {
TEST_F('OSSettingsAppManagementManagedAppTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -299,8 +289,7 @@ var OSSettingsAppManagementReducersTest = ...@@ -299,8 +289,7 @@ var OSSettingsAppManagementReducersTest =
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsAppManagementReducersTest', 'AllJsTests', () => {
TEST_F('OSSettingsAppManagementReducersTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -574,8 +563,7 @@ var OSSettingsMainTest = class extends OSSettingsBrowserTest { ...@@ -574,8 +563,7 @@ var OSSettingsMainTest = class extends OSSettingsBrowserTest {
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsMainTest', 'AllJsTests', () => {
TEST_F('OSSettingsMainTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -591,8 +579,7 @@ var OSSettingsMenuTest = class extends OSSettingsBrowserTest { ...@@ -591,8 +579,7 @@ var OSSettingsMenuTest = class extends OSSettingsBrowserTest {
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsMenuTest', 'AllJsTests', () => {
TEST_F('OSSettingsMenuTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -860,8 +847,7 @@ var OSSettingsPeoplePageTest = class extends OSSettingsBrowserTest { ...@@ -860,8 +847,7 @@ var OSSettingsPeoplePageTest = class extends OSSettingsBrowserTest {
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsPeoplePageTest', 'AllJsTests', () => {
TEST_F('OSSettingsPeoplePageTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -879,8 +865,7 @@ var OSSettingsPersonalizationPageTest = class extends OSSettingsBrowserTest { ...@@ -879,8 +865,7 @@ var OSSettingsPersonalizationPageTest = class extends OSSettingsBrowserTest {
} }
}; };
// Failing on linux-chromeos-dbg bot, see https://crbug.com/1013094 TEST_F('OSSettingsPersonalizationPageTest', 'AllJsTests', () => {
TEST_F('OSSettingsPersonalizationPageTest', 'DISABLED_AllJsTests', () => {
mocha.run(); mocha.run();
}); });
...@@ -1084,4 +1069,4 @@ TEST_F('OSSettingsSmbPageTest', 'AllJsTests', () => { ...@@ -1084,4 +1069,4 @@ TEST_F('OSSettingsSmbPageTest', 'AllJsTests', () => {
mocha.run(); mocha.run();
}); });
// GEN('#endif // defined(NDEBUG)'); GEN('#endif // defined(NDEBUG)');
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment