Commit e8709517 authored by My Nguyen's avatar My Nguyen Committed by Commit Bot

[EmojiSuggest] Remove accept suggestion with number

As per UX guidance, since the number is removed, accept suggestion with
number functionality should also be removed.

Bug: b/165761951
Change-Id: I45a51c1e4262949b298c0470571f4c57e5ee2f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371482Reviewed-by: default avatarKeith Lee <keithlee@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801191}
parent 4e4205d2
......@@ -188,10 +188,6 @@ SuggestionStatus EmojiSuggester::HandleKeyEvent(
}
SetButtonHighlighted(buttons_[highlighted_index_], true);
return SuggestionStatus::kBrowsing;
} else {
int choice = 0;
if (base::StringToInt(event.key, &choice) && AcceptSuggestion(choice - 1))
return SuggestionStatus::kAccept;
}
}
......
......@@ -185,24 +185,13 @@ TEST_F(EmojiSuggesterTest, ReturnkDismissWhenPressingEsc) {
emoji_suggester_->HandleKeyEvent(event));
}
TEST_F(EmojiSuggesterTest, ReturnkAcceptWhenPressDownThenValidNumber) {
TEST_F(EmojiSuggesterTest, ReturnkNotHandledWhenPressDownThenValidNumber) {
EXPECT_TRUE(emoji_suggester_->Suggest(base::UTF8ToUTF16("happy ")));
InputMethodEngineBase::KeyboardEvent event1;
event1.key = "Down";
emoji_suggester_->HandleKeyEvent(event1);
InputMethodEngineBase::KeyboardEvent event2;
event2.key = "1";
EXPECT_EQ(SuggestionStatus::kAccept,
emoji_suggester_->HandleKeyEvent(event2));
}
TEST_F(EmojiSuggesterTest, ReturnkNotHandledWhenPressDownThenNumberNotInRange) {
EXPECT_TRUE(emoji_suggester_->Suggest(base::UTF8ToUTF16("happy ")));
InputMethodEngineBase::KeyboardEvent event1;
event1.key = "Down";
emoji_suggester_->HandleKeyEvent(event1);
InputMethodEngineBase::KeyboardEvent event2;
event2.key = "4";
EXPECT_EQ(SuggestionStatus::kNotHandled,
emoji_suggester_->HandleKeyEvent(event2));
}
......@@ -218,20 +207,6 @@ TEST_F(EmojiSuggesterTest, ReturnkNotHandledWhenPressDownThenNotANumber) {
emoji_suggester_->HandleKeyEvent(event2));
}
TEST_F(EmojiSuggesterTest, ReturnkAcceptWhenPressDownThenUpThenANumber) {
EXPECT_TRUE(emoji_suggester_->Suggest(base::UTF8ToUTF16("happy ")));
InputMethodEngineBase::KeyboardEvent event1;
event1.key = "Down";
emoji_suggester_->HandleKeyEvent(event1);
InputMethodEngineBase::KeyboardEvent event2;
event2.key = "Up";
emoji_suggester_->HandleKeyEvent(event2);
InputMethodEngineBase::KeyboardEvent event3;
event3.key = "1";
EXPECT_EQ(SuggestionStatus::kAccept,
emoji_suggester_->HandleKeyEvent(event3));
}
TEST_F(EmojiSuggesterTest,
ReturnkNotHandledWhenPressingEnterAndACandidateHasNotBeenChosen) {
EXPECT_TRUE(emoji_suggester_->Suggest(base::UTF8ToUTF16("happy ")));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment