Commit e876485d authored by Katie Dektar's avatar Katie Dektar Committed by Commit Bot

Remove select-to-speak option where search key locks speaking mode.

This "mode" was actually a bug.

Bug: 792557
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I888cd8c3184f42a3dc3c0fdc1c85d747a2e0090f
Reviewed-on: https://chromium-review.googlesource.com/811590Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522232}
parent 37234337
...@@ -75,28 +75,6 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, SpeakStatusTray) { ...@@ -75,28 +75,6 @@ IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, SpeakStatusTray) {
base::MatchPattern(speech_monitor_.GetNextUtterance(), "Status tray*")); base::MatchPattern(speech_monitor_.GetNextUtterance(), "Status tray*"));
} }
IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, SearchLocksToSelectToSpeakMode) {
ui_test_utils::NavigateToURL(browser(), GURL("data:text/html;charset=utf-8,"
"<p>This is some text</p>"));
gfx::Rect bounds = browser()->window()->GetBounds();
// Hold click Search, then and click a few pixels into the window bounds.
generator_->PressKey(ui::VKEY_LWIN, 0 /* flags */);
generator_->ReleaseKey(ui::VKEY_LWIN, 0 /* flags */);
for (int i = 0; i < 2; ++i) {
// With the mouse only, have it speak a few times.
generator_->MoveMouseTo(bounds.x() + 8, bounds.y() + 50);
generator_->PressLeftButton();
generator_->MoveMouseTo(bounds.x() + bounds.width() - 8,
bounds.y() + bounds.height() - 8);
generator_->ReleaseLeftButton();
EXPECT_TRUE(base::MatchPattern(speech_monitor_.GetNextUtterance(),
"This is some text*"));
}
}
IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, SmoothlyReadsAcrossInlineUrl) { IN_PROC_BROWSER_TEST_F(SelectToSpeakTest, SmoothlyReadsAcrossInlineUrl) {
// Make sure an inline URL is read smoothly. // Make sure an inline URL is read smoothly.
ActivateSelectToSpeakInWindowBounds( ActivateSelectToSpeakInWindowBounds(
......
...@@ -392,6 +392,8 @@ SelectToSpeak.prototype = { ...@@ -392,6 +392,8 @@ SelectToSpeak.prototype = {
* @return {boolean} True if the default action should be performed. * @return {boolean} True if the default action should be performed.
*/ */
onMouseUp_: function(evt) { onMouseUp_: function(evt) {
if (!this.trackingMouse_)
return false;
this.onMouseMove_(evt); this.onMouseMove_(evt);
this.trackingMouse_ = false; this.trackingMouse_ = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment