Commit e8a1da48 authored by Joshua Bell's avatar Joshua Bell Committed by Commit Bot

Web Locks API: Fix IDL glitch

A callback defined in Web IDL should take a nullable argument. We
don't enforce this in our bindings code and it can't be introspected
from JS so this is not a testable or web-facing change, just aligning
the code with a spec fix.

Spec issue: https://github.com/WICG/web-locks/issues/51
Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback

Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4
Reviewed-on: https://chromium-review.googlesource.com/c/1294421
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601716}
parent 9e109cce
...@@ -16,7 +16,7 @@ interface LockManager { ...@@ -16,7 +16,7 @@ interface LockManager {
Promise<LockManagerSnapshot> query(); Promise<LockManagerSnapshot> query();
}; };
callback LockGrantedCallback = Promise<any> (Lock lock); callback LockGrantedCallback = Promise<any> (Lock? lock);
enum LockMode { "shared", "exclusive" }; enum LockMode { "shared", "exclusive" };
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
// https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback // https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback
callback LockGrantedCallback = any (Lock lock); callback LockGrantedCallback = any (Lock? lock);
// https://wicg.github.io/web-locks/#lockmanager // https://wicg.github.io/web-locks/#lockmanager
[ [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment