Skip to content

GitLab

T
tangled
Commit e8a4d4fa authored by Shakti Sahu's avatar Shakti Sahu Committed by Commit Bot
Browse files
Options

Read later : Added more strings 

Added two missing strings to show on reading list page when the list
is empty.

Bug: 1148480
Change-Id: Ifee700a0c873058e883a5a151ec14415cc4f2d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535016
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826963}
parent 0935a0c7
Hide whitespace changes
Inline Side-by-side
Showing with 16 additions and 1 deletion
chrome/android/expectations/lint-suppressions.xml
View file @ e8a4d4fa
......@@ -235,7 +235,7 @@ Still reading?
<ignore regexp="The resource `R.string.accessibility_close_tab_group_button_with_group_name` appears to be unused"/>
<ignore regexp="The resource `R.string.accessibility_expand_tab_group_with_group_name` appears to be unused"/>
<!-- crbug.com/1128074 remove this line and following 9 lines after the bug is resolved -->
<!-- crbug.com/1128074 remove this line and following 12 lines after the bug is resolved -->
<ignore regexp="The resource `R.string.reading_list_title` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_read` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_unread` appears to be unused"/>
......@@ -247,6 +247,9 @@ Still reading?
<ignore regexp="The resource `R.plurals.reading_list_unread_page_count` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_intro_text` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_find_in_bookmarks` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_empty_list_title` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_empty_list_description` appears to be unused"/>
<ignore regexp="The resource `R.string.reading_list_empty_list_description_offline` appears to be unused"/>
<!-- crbug.com/1127531 remove this line and following 9 lines after the bug is resolved -->
<ignore regexp="The resource `R.string.app_language_title` appears to be unused"/>
......
chrome/browser/ui/android/strings/android_chrome_strings.grd
View file @ e8a4d4fa
......@@ -3118,6 +3118,15 @@ Data from your Incognito session will only be cleared from Chrome when you <ph n
<message name="IDS_READING_LIST_FIND_IN_BOOKMARKS" desc="The text to inform the user to find the reading list in bookmarks UI.">
Find your reading list in Bookmarks
</message>
<message name="IDS_READING_LIST_EMPTY_LIST_TITLE" desc="The text on reading list page when there are no reading list items informing user that reading list is supposed to appear on this surface.">
You’ll find your reading list here
</message>
<message name="IDS_READING_LIST_EMPTY_LIST_DESCRIPTION" desc="The description text on reading list page when there are no reading list items informing user that they can save articles to read later which will appear on this surface.">
You can save pages to your reading list to find them again
</message>
<message name="IDS_READING_LIST_EMPTY_LIST_DESCRIPTION_OFFLINE" desc="The description text on reading list page when there are no reading list items informing user that they can save articles to read later offline which will appear on this surface.">
You can save pages to your reading list to find them again or read offline
</message>
<!-- Offline pages -->
<message name="IDS_OFFLINE_PAGES_VIEWING_OFFLINE_PAGE" desc="Text explaining that the user is viewing an offline copy of a web page.">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment