Commit e8a6b3c6 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[Passwords] Add UI Flag for Leak Detection

This change adds a UI flag for the password leak detection feature.

Bug: 986298
Change-Id: I0dde3c0afa4464bd97bd11c57b8fa7b5de7a8600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761605
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688512}
parent 9692e842
......@@ -4346,6 +4346,10 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE(features::kProfileMenuRevamp)},
#endif // defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
{"password-leak-detection", flag_descriptions::kPasswordLeakDetectionName,
flag_descriptions::kPasswordLeakDetectionDescription, kOsAll,
FEATURE_VALUE_TYPE(password_manager::features::kLeakDetection)},
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
......
......@@ -2720,6 +2720,11 @@
"owners": [ "izuzic", "fhorschig" ],
"expiry_milestone": 80
},
{
"name": "password-leak-detection",
"owners": [ "jdoerrie", "vasilii" ],
"expiry_milestone": 80
},
{
"name": "password-manager-onboarding-android",
"owners": ["achulkov", "ioanap"],
......
......@@ -1528,6 +1528,10 @@ const char kPasswordImportName[] = "Password import";
const char kPasswordImportDescription[] =
"Import functionality in password settings.";
const char kPasswordLeakDetectionName[] = "Password Leak Detection";
const char kPasswordLeakDetectionDescription[] =
"Enables the detection of leaked passwords.";
const char kForceWebContentsDarkModeName[] = "Force Dark Mode for Web Contents";
const char kForceWebContentsDarkModeDescription[] =
"Automatically render all web contents using a dark theme.";
......
......@@ -918,6 +918,9 @@ extern const char kPassiveDocumentWheelEventListenersDescription[];
extern const char kPasswordImportName[];
extern const char kPasswordImportDescription[];
extern const char kPasswordLeakDetectionName[];
extern const char kPasswordLeakDetectionDescription[];
extern const char kForceWebContentsDarkModeName[];
extern const char kForceWebContentsDarkModeDescription[];
......
......@@ -34688,6 +34688,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.-->
label="OmniboxUIExperimentShowPlaceholderWhenCaretShowing:disabled"/>
<int value="-1454479680" label="FileHandlingAPI:enabled"/>
<int value="-1454397907" label="OptimizationHints:disabled"/>
<int value="-1453647118" label="PasswordLeakDetection:disabled"/>
<int value="-1451644187" label="OverviewSwipeToClose:enabled"/>
<int value="-1450576851" label="OmniboxUIExperimentVerticalLayout:enabled"/>
<int value="-1448511207" label="UseMessagesStagingUrl:disabled"/>
......@@ -36855,6 +36856,7 @@ from previous Chrome versions.
<int value="1567839560"
label="ChromeHomePersonalizedOmniboxSuggestions:disabled"/>
<int value="1571998166" label="DetectingHeavyPages:disabled"/>
<int value="1575978252" label="PasswordLeakDetection:enabled"/>
<int value="1577205328"
label="DataReductionProxyEnabledWithNetworkService:enabled"/>
<int value="1579461102" label="MemoryCoordinator:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment