Add initialization of RTCPeerConnectionHandler for tests.

This avoids some MSAN error messages.

Bug: chromium:787254
Change-Id: If01797d8bd1a57ea44a151ad3bdd74e3cb4aecc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152365
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759612}

third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc

@@ -1061,10 +1061,7 @@ RTCPeerConnectionHandler::RTCPeerConnectionHandler(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner,
     bool force_encoded_audio_insertable_streams,
     bool force_encoded_video_insertable_streams)
-    : initialize_called_(false),
-      client_(client),
-      is_closed_(false),
-      is_unregistered_(false),
+    : client_(client),
       dependency_factory_(dependency_factory),
       track_adapter_map_(
           base::MakeRefCounted<blink::WebRtcMediaStreamTrackAdapterMap>(
@@ -1083,8 +1080,7 @@ RTCPeerConnectionHandler::RTCPeerConnectionHandler(
 // Constructor to be used for creating mocks only.
 RTCPeerConnectionHandler::RTCPeerConnectionHandler(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner)
-    : client_(nullptr),
-      dependency_factory_(nullptr),
+    : is_unregistered_(true),  // Avoid StopAndUnregister in destructor
       task_runner_(std::move(task_runner)) {}
 
 RTCPeerConnectionHandler::~RTCPeerConnectionHandler() {

third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.h

@@ -371,20 +371,20 @@ class MODULES_EXPORT RTCPeerConnectionHandler {
 
   // Initialize() is never expected to be called more than once, even if the
   // first call fails.
-  bool initialize_called_;
+  bool initialize_called_ = false;
 
   // |client_| is a raw pointer to the blink object (blink::RTCPeerConnection)
   // that owns this object.
   // It is valid for the lifetime of this object, but is cleared when
   // StopAndUnregister() is called, in order to make sure it doesn't
   // interfere with garbage collection of the owner object.
-  RTCPeerConnectionHandlerClient* client_;
+  RTCPeerConnectionHandlerClient* client_ = nullptr;
   // True if this PeerConnection has been closed.
   // After the PeerConnection has been closed, this object may no longer
   // forward callbacks to blink.
-  bool is_closed_;
+  bool is_closed_ = false;
   // True if StopAndUnregister has been called.
-  bool is_unregistered_;
+  bool is_unregistered_ = false;
 
   // Transition from kHaveLocalOffer to kHaveRemoteOffer indicates implicit
   // rollback in which case we need to also make visiting of kStable observable.
@@ -393,7 +393,7 @@ class MODULES_EXPORT RTCPeerConnectionHandler {
 
   // |dependency_factory_| is a raw pointer, and is valid for the lifetime of
   // RenderThreadImpl.
-  blink::PeerConnectionDependencyFactory* const dependency_factory_;
+  blink::PeerConnectionDependencyFactory* const dependency_factory_ = nullptr;
 
   blink::WebLocalFrame* frame_ = nullptr;
 
@@ -441,8 +441,8 @@ class MODULES_EXPORT RTCPeerConnectionHandler {
   // used when constructing the PeerConnection carry over when
   // SetConfiguration is called.
   webrtc::PeerConnectionInterface::RTCConfiguration configuration_;
-  bool force_encoded_audio_insertable_streams_;
-  bool force_encoded_video_insertable_streams_;
+  bool force_encoded_audio_insertable_streams_ = false;
+  bool force_encoded_video_insertable_streams_ = false;
 
   // Record info about the first SessionDescription from the local and
   // remote side to record UMA stats once both are set.  We only check