Add flag for password change button

Bug: 1053522

Change-Id: Ie1c851e25d323f0252ec7503ecd02aba5c5daba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062268
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742568}

chrome/browser/about_flags.cc

@@ -4947,6 +4947,10 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(chromeos::features::kAmbientModeFeature)},
 #endif  // defined(OS_CHROMEOS)
 
+    {"password-change-support", flag_descriptions::kPasswordChangeName,
+     flag_descriptions::kPasswordChangeDescription, kOsAll,
+     FEATURE_VALUE_TYPE(password_manager::features::kPasswordChange)},
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

chrome/browser/flag-metadata.json

@@ -3050,6 +3050,11 @@
     "owners": [ "carlosil", "estark" ],
     "expiry_milestone": 83
   },
+  {
+    "name": "password-change-support",
+    "owners": [ "selakovic" ],
+    "expiry_milestone": 85
+  },
   {
     "name": "password-check",
     "owners": [ "jdoerrie", "vasilii" ],

chrome/browser/flag_descriptions.cc

@@ -1498,6 +1498,10 @@ const char kPassiveMixedContentWarningDescription[] =
     "Causes a 'Not Secure' chip to be shown in the omnibox if a site contains "
     "passive (aka optionally blockable) mixed content.";
 
+const char kPasswordChangeName[] = "Rework password change flow";
+const char kPasswordChangeDescription[] =
+    "Change password when password leak is detected.";
+
 const char kPasswordEditingAndroidName[] = "Password editing for Android";
 const char kPasswordEditingAndroidDescription[] =
     "Adds the editing option for saved passwords.";

chrome/browser/flag_descriptions.h

@@ -860,6 +860,9 @@ extern const char kOverscrollHistoryNavigationDescription[];
 extern const char kParallelDownloadingName[];
 extern const char kParallelDownloadingDescription[];
 
+extern const char kPasswordChangeName[];
+extern const char kPasswordChangeDescription[];
+
 extern const char kPasswordEditingAndroidName[];
 extern const char kPasswordEditingAndroidDescription[];
 

components/password_manager/core/common/password_manager_features.cc

@@ -48,6 +48,10 @@ const base::Feature kFillOnAccountSelect = {"fill-on-account-select",
 const base::Feature kGooglePasswordManager = {
     "google-password-manager", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enables password change flow from leaked password dialog.
+const base::Feature kPasswordChange = {"PasswordChange",
+                                       base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Enables the bulk Password Check feature for signed in users.
 const base::Feature kPasswordCheck = {"PasswordCheck",
                                       base::FEATURE_DISABLED_BY_DEFAULT};

components/password_manager/core/common/password_manager_features.h

@@ -25,6 +25,7 @@ extern const base::Feature kEnablePasswordsAccountStorage;
 extern const base::Feature KEnablePasswordGenerationForClearTextFields;
 extern const base::Feature kFillOnAccountSelect;
 extern const base::Feature kGooglePasswordManager;
+extern const base::Feature kPasswordChange;
 extern const base::Feature kPasswordCheck;
 extern const base::Feature kPasswordEditingAndroid;
 extern const base::Feature kPasswordImport;

tools/metrics/histograms/enums.xml

@@ -36946,6 +36946,7 @@ from previous Chrome versions.
   <int value="-2075725205" label="disable-new-zip-unpacker"/>
   <int value="-2074080173" label="NightLight:disabled"/>
   <int value="-2071515296" label="allow-sync-xhr-in-page-dismissal"/>
+  <int value="-2068490665" label="PasswordChange:enabled"/>
   <int value="-2067166422" label="enable-slimming-paint-v2"/>
   <int value="-2066541315" label="Mus:enabled"/>
   <int value="-2064164557" label="DownloadsForeground:disabled"/>
@@ -37105,6 +37106,7 @@ from previous Chrome versions.
   <int value="-1899409297"
       label="ProcessSharingWithStrictSiteInstances:disabled"/>
   <int value="-1898386671" label="PasswordCheck:enabled"/>
+  <int value="-1896394207" label="PasswordChange:disabled"/>
   <int value="-1895719323" label="VrBrowsingTabsView:enabled"/>
   <int value="-1894699049" label="AudioFocusEnforcement:disabled"/>
   <int value="-1894054576" label="FontAccess:enabled"/>