[Nearby] Do not populate ID list in ListPublicCertificates request

The ListPublicCertificates RPC has an optional field in the request
where the client can list the IDs on all locally stored public
certificates. Certificates with these IDs will not be returned in the
response. However, this RPC is made in Chromium via an HTTP GET
request, and One Platform documentation notes request-URL size
limits [1].

There are ways to circumvent these size restrictions, but until the
Nearby Share server makes the appropriate changes to the API, we will
not send the ID list.

[1]https://g3doc.corp.google.com/google/g3doc/oneplatform/http.md#long-request-url

Bug: b/168701170
Change-Id: Ieec8ad883c152769006c9c8dd94a0341ff46dd3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423323
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809191}

chrome/browser/nearby_sharing/certificates/nearby_share_certificate_manager_impl.cc

@@ -526,10 +526,10 @@ void NearbyShareCertificateManagerImpl::OnDownloadPublicCertificatesRequest(
   if (page_token)
     request.set_page_token(*page_token);
 
-  for (const std::string& id :
-       certificate_storage_->GetPublicCertificateIds()) {
-    request.add_secret_ids(id);
-  }
+  // TODO(b/168701170): One Platform has a length restriction on request URLs.
+  // Adding all secret IDs to the request, and subsequently as query parameters,
+  // could result in hitting this limit. Add the secret IDs of all locally
+  // stored public certificates when this length restriction is circumvented.
 
   NS_LOG(VERBOSE) << __func__ << ": Downloading public certificates.";
 
@@ -539,8 +539,6 @@ void NearbyShareCertificateManagerImpl::OnDownloadPublicCertificatesRequest(
           &NearbyShareCertificateManagerImpl::OnListPublicCertificatesTimeout,
           base::Unretained(this), page_number, certificate_count));
 
-  // TODO(https://crbug.com/1116910): Enforce a timeout for each
-  // ListPublicCertificates call.
   client_ = client_factory_->CreateInstance();
   client_->ListPublicCertificates(
       request,

chrome/browser/nearby_sharing/certificates/nearby_share_certificate_manager_impl_unittest.cc

@@ -320,11 +320,14 @@ class NearbyShareCertificateManagerImplTest
       const nearbyshare::proto::ListPublicCertificatesRequest& request,
       const std::string& page_token) {
     EXPECT_EQ(request.parent(), std::string(kDeviceIdPrefix) + kDeviceId);
-    ASSERT_EQ(request.secret_ids_size(),
-              static_cast<int>(kPublicCertificateIds.size()));
-    for (size_t i = 0; i < kPublicCertificateIds.size(); ++i) {
-      EXPECT_EQ(request.secret_ids(i), kPublicCertificateIds[i]);
-    }
+
+    // TODO(b/168701170): One Platform has a length restriction on request URLs.
+    // Adding all secret IDs to the request, and subsequently as query
+    // parameters, could result in hitting this limit. Add the secret IDs of all
+    // locally stored public certificates when this length restriction is
+    // circumvented.
+    EXPECT_TRUE(request.secret_ids().empty());
+
     EXPECT_EQ(request.page_token(), page_token);
   }