Commit e8df742a authored by Jochen Eisinger's avatar Jochen Eisinger Committed by Commit Bot

Reenable BrowserTest.WindowOpenClose3 on Mac

We no longer should wait for frames in tests, so this should pass again

R=ccameron@chromium.org
BUG=772576,753691

Change-Id: I9ff676c05fff3fa2d79e1a22edb4ec25ef5e5806
Reviewed-on: https://chromium-review.googlesource.com/1146191Reviewed-by: default avatarccameron <ccameron@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577219}
parent ffaf6d76
...@@ -121,6 +121,7 @@ ...@@ -121,6 +121,7 @@
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#include "base/mac/scoped_nsautorelease_pool.h" #include "base/mac/scoped_nsautorelease_pool.h"
#include "chrome/browser/ui/cocoa/test/run_loop_testing.h" #include "chrome/browser/ui/cocoa/test/run_loop_testing.h"
#include "ui/accelerated_widget_mac/ca_transaction_observer.h"
#endif #endif
#if defined(OS_WIN) #if defined(OS_WIN)
...@@ -1907,15 +1908,17 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_WindowOpenClose2) { ...@@ -1907,15 +1908,17 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_WindowOpenClose2) {
EXPECT_EQ(title, title_watcher.WaitAndGetTitle()); EXPECT_EQ(title, title_watcher.WaitAndGetTitle());
} }
#if defined(OS_MACOSX) || (defined(OS_WIN) && !defined(NDEBUG)) #if (defined(OS_WIN) && !defined(NDEBUG))
// Times out on windows (dbg). https://crbug.com/753691. // Times out on windows (dbg). https://crbug.com/753691.
// Also times out on macOS (can be made to pass by lowering kPaintMsgTimeoutMS
// in RenderWidgetHostImpl).
#define MAYBE_WindowOpenClose3 DISABLED_WindowOpenClose3 #define MAYBE_WindowOpenClose3 DISABLED_WindowOpenClose3
#else #else
#define MAYBE_WindowOpenClose3 WindowOpenClose3 #define MAYBE_WindowOpenClose3 WindowOpenClose3
#endif #endif
IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_WindowOpenClose3) { IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_WindowOpenClose3) {
#if defined(OS_MACOSX)
// Ensure that tests don't wait for frames that will never come.
ui::CATransactionCoordinator::Get().DisableForTesting();
#endif
base::CommandLine::ForCurrentProcess()->AppendSwitch( base::CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisablePopupBlocking); switches::kDisablePopupBlocking);
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment