Skip to content

GitLab

T
tangled
Commit e909a507 authored by David Dorwin's avatar David Dorwin Committed by Commit Bot
Browse files
Options

Restructure WebXR & WebVR Feature Policy tests 

https://crrev.com/c/1387151 added a test to webvr/ that checks for "xr".
The WebVR API is obsolete, and only "vr" was used with it.

This CL copies the test for "xr" to the webxr/ tests and changes the
webvr/ test to check for "vr".

Change-Id: I0481afc1ad0c1445bf744c1b99307e482f2315af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600152Reviewed-by: default avatarIan Clelland <iclelland@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659077}
parent 6d3f313e
Hide whitespace changes
Inline Side-by-side
Showing with 22 additions and 7 deletions
third_party/blink/web_tests/TestExpectations
View file @ e909a507
......@@ -2144,6 +2144,7 @@ crbug.com/472330 fast/writing-mode/table-percent-width-quirk.html [ Failure ]
# These are the failing tests because Chrome hasn't implemented according to the spec.
crbug.com/645988 external/wpt/uievents/order-of-events/focus-events/focus-manual.html [ Failure ]
# TODO(https://crbug.com/960132): Remove these when WebVR is removed.
crbug.com/807152 vr/VRDisplay_rAF_fires_with_window_rAF.html [ Pass Failure ]
crbug.com/813697 vr/getFrameData_oneframeupdate.html [ Pass Failure ]
......@@ -5276,8 +5277,9 @@ crbug.com/921242 [ Mac ] fast/overflow/clip-rects-fixed-ancestor.html [ Failure
# Sheriff 2019-01-24
crbug.com/924954 http/tests/images/feature-policy-image-policies-with-border-radius.html [ Pass Failure ]
# WebXR feature policy feature name in Chrome doesn't match spec.
crbug.com/924670 external/wpt/webvr/webvr-supported-by-feature-policy.html [ Failure ]
# Chrome does not implement the feature policy name currently in the spec,
# which is still in flux.
crbug.com/924670 external/wpt/webxr/webxr-supported-by-feature-policy.html [ Failure ]
crbug.com/961015 [ Mac ] external/wpt/webxr/xrSession_requestAnimationFrame_callback_calls.https.html [ Timeout ]
crbug.com/961015 [ Mac ] external/wpt/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html [ Timeout ]
......
third_party/blink/web_tests/external/wpt/webvr/webvr-supported-by-feature-policy.html
View file @ e909a507
<!DOCTYPE html>
<title>Test that xr is advertised in the feature list</title>
<link rel="help" href="https://w3c.github.io/webappsec-feature-policy/#dom-featurepolicy-features">
<link rel="help" href="https://immersive-web.github.io/webxr/#feature-policy">
<title>Test that (obsolete) vr is advertised in the feature list</title>
<!-- Some WebVR implementations used "vr", but this is now obsolete and WebXR is moving in a different direction.-->>
<link rel="help" href="https://github.com/immersive-web/webxr/issues/308">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
test(() => {
assert_in_array('xr', document.featurePolicy.features());
}, 'document.featurePolicy.features should advertise xr.');
assert_in_array('vr', document.featurePolicy.features());
}, 'document.featurePolicy.features should advertise (obsolete) vr.');
</script>
third_party/blink/web_tests/external/wpt/webxr/webxr-supported-by-feature-policy.html 0 → 100644
View file @ e909a507
<!DOCTYPE html>
<title>Test that xr is advertised in the feature list</title>
<!-- The Feature Policy feature name(s) for WebXR are still TBD. See the issue below. This test checks what is currently in the spec. -->
<link rel="help" href="https://github.com/immersive-web/webxr/issues/308">
<link rel="help" href="https://w3c.github.io/webappsec-feature-policy/#dom-featurepolicy-features">
<link rel="help" href="https://immersive-web.github.io/webxr/#feature-policy">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
test(() => {
assert_in_array('xr', document.featurePolicy.features());
}, 'document.featurePolicy.features should advertise xr.');
</script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment