Commit e925bf1a authored by Hidy Han's avatar Hidy Han Committed by Commit Bot

Emit hasUserGesture bit in Network.requestWillBeSent.

Change-Id: I688b76fee2fc9b5aa2ac6b83fb0c818e20bc8741
Reviewed-on: https://chromium-review.googlesource.com/950237
Commit-Queue: Hidy Han <hidyhan@chromium.org>
Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541518}
parent dc262b06
...@@ -1264,7 +1264,8 @@ void NetworkHandler::NavigationRequestWillBeSent( ...@@ -1264,7 +1264,8 @@ void NetworkHandler::NavigationRequestWillBeSent(
id, id, StripFragment(common_params.url), std::move(request), id, id, StripFragment(common_params.url), std::move(request),
current_ticks, current_wall_time, std::move(initiator), current_ticks, current_wall_time, std::move(initiator),
std::move(redirect_response), std::move(redirect_response),
std::string(Page::ResourceTypeEnum::Document), std::move(frame_token)); std::string(Page::ResourceTypeEnum::Document), std::move(frame_token),
common_params.has_user_gesture);
} }
void NetworkHandler::RequestSent(const std::string& request_id, void NetworkHandler::RequestSent(const std::string& request_id,
...@@ -1290,7 +1291,8 @@ void NetworkHandler::RequestSent(const std::string& request_id, ...@@ -1290,7 +1291,8 @@ void NetworkHandler::RequestSent(const std::string& request_id,
base::Time::Now().ToDoubleT(), base::Time::Now().ToDoubleT(),
Network::Initiator::Create().SetType(initiator_type).Build(), Network::Initiator::Create().SetType(initiator_type).Build(),
std::unique_ptr<Network::Response>(), std::unique_ptr<Network::Response>(),
std::string(Page::ResourceTypeEnum::Other)); std::string(Page::ResourceTypeEnum::Other),
Maybe<std::string>() /* frame_id */, request.has_user_gesture);
} }
void NetworkHandler::ResponseReceived(const std::string& request_id, void NetworkHandler::ResponseReceived(const std::string& request_id,
...@@ -1369,7 +1371,9 @@ void NetworkHandler::NavigationFailed(NavigationRequest* navigation_request) { ...@@ -1369,7 +1371,9 @@ void NetworkHandler::NavigationFailed(NavigationRequest* navigation_request) {
.SetType(Network::Initiator::TypeEnum::Parser) .SetType(Network::Initiator::TypeEnum::Parser)
.Build(), .Build(),
std::unique_ptr<Network::Response>(), std::unique_ptr<Network::Response>(),
std::string(Page::ResourceTypeEnum::Document)); std::string(Page::ResourceTypeEnum::Document),
Maybe<std::string>() /* frame_id */,
navigation_request->common_params().has_user_gesture);
frontend_->LoadingFailed( frontend_->LoadingFailed(
request_id, request_id,
......
...@@ -793,7 +793,7 @@ void InspectorNetworkAgent::WillSendRequestInternal( ...@@ -793,7 +793,7 @@ void InspectorNetworkAgent::WillSendRequestInternal(
request_id, loader_id, documentURL, std::move(request_info), request_id, loader_id, documentURL, std::move(request_info),
CurrentTimeTicksInSeconds(), CurrentTime(), std::move(initiator_object), CurrentTimeTicksInSeconds(), CurrentTime(), std::move(initiator_object),
BuildObjectForResourceResponse(redirect_response), resource_type, BuildObjectForResourceResponse(redirect_response), resource_type,
std::move(maybe_frame_id)); std::move(maybe_frame_id), request.HasUserGesture());
if (pending_xhr_replay_data_ && !pending_xhr_replay_data_->Async()) if (pending_xhr_replay_data_ && !pending_xhr_replay_data_->Async())
GetFrontend()->flush(); GetFrontend()->flush();
} }
......
...@@ -8750,6 +8750,12 @@ ...@@ -8750,6 +8750,12 @@
"description": "Frame identifier.", "description": "Frame identifier.",
"optional": true, "optional": true,
"$ref": "Page.FrameId" "$ref": "Page.FrameId"
},
{
"name": "hasUserGesture",
"description": "Whether the request is initiated by a user gesture. Defaults to false.",
"optional": true,
"type": "boolean"
} }
] ]
}, },
......
...@@ -3990,6 +3990,8 @@ domain Network ...@@ -3990,6 +3990,8 @@ domain Network
optional Page.ResourceType type optional Page.ResourceType type
# Frame identifier. # Frame identifier.
optional Page.FrameId frameId optional Page.FrameId frameId
# Whether the request is initiated by a user gesture. Defaults to false.
optional boolean hasUserGesture
# Fired when resource loading priority is changed # Fired when resource loading priority is changed
experimental event resourceChangedPriority experimental event resourceChangedPriority
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment