Commit e93f2c58 authored by dpapad's avatar dpapad Committed by Commit Bot

Extensions WebUI: Fix a11y tests to work with Polymer 2.

Basically eliminating usage of /deep/ selectors.

Bug: 875449,860069
Change-Id: I7e53055b712ee6701f240ba6f50c9eb1918d88b1
Reviewed-on: https://chromium-review.googlesource.com/1233113Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592474}
parent bf8f4d1c
...@@ -99,7 +99,7 @@ AccessibilityTest.define('CrExtensionsA11yTest', { ...@@ -99,7 +99,7 @@ AccessibilityTest.define('CrExtensionsA11yTest', {
/** @override */ /** @override */
tests: { tests: {
'Accessible with No Extensions': function() { 'Accessible with No Extensions': function() {
let list = document.querySelector('* /deep/ #items-list'); let list = document.querySelector('extensions-manager').$$('#items-list');
assertEquals(list.extensions.length, 0); assertEquals(list.extensions.length, 0);
assertEquals(list.apps.length, 0); assertEquals(list.apps.length, 0);
} }
...@@ -129,7 +129,7 @@ AccessibilityTest.define('CrExtensionsA11yTestWithMultipleExensions', { ...@@ -129,7 +129,7 @@ AccessibilityTest.define('CrExtensionsA11yTestWithMultipleExensions', {
/** @override */ /** @override */
tests: { tests: {
'Accessible with Extensions and Apps': function() { 'Accessible with Extensions and Apps': function() {
let list = document.querySelector('* /deep/ #items-list'); let list = document.querySelector('extensions-manager').$$('#items-list');
assertEquals(list.extensions.length, 1); assertEquals(list.extensions.length, 1);
assertEquals(list.apps.length, 3); assertEquals(list.apps.length, 3);
}, },
...@@ -157,8 +157,8 @@ AccessibilityTest.define('CrExtensionsShortcutA11yTestWithNoExtensions', { ...@@ -157,8 +157,8 @@ AccessibilityTest.define('CrExtensionsShortcutA11yTestWithNoExtensions', {
/** @override */ /** @override */
tests: { tests: {
'Accessible with No Extensions or Apps': function() { 'Accessible with No Extensions or Apps': function() {
let list = let list = document.querySelector('extensions-manager')
document.querySelector('* /deep/ extensions-keyboard-shortcuts'); .$$('extensions-keyboard-shortcuts');
assertEquals(list.items.length, 0); assertEquals(list.items.length, 0);
}, },
}, },
...@@ -185,8 +185,8 @@ AccessibilityTest.define('CrExtensionsShortcutA11yTestWithExtensions', { ...@@ -185,8 +185,8 @@ AccessibilityTest.define('CrExtensionsShortcutA11yTestWithExtensions', {
/** @override */ /** @override */
tests: { tests: {
'Accessible with Extensions': function() { 'Accessible with Extensions': function() {
let list = let list = document.querySelector('extensions-manager')
document.querySelector('* /deep/ extensions-keyboard-shortcuts'); .$$('extensions-keyboard-shortcuts');
assertEquals(list.items.length, 1); assertEquals(list.items.length, 1);
}, },
}, },
...@@ -225,7 +225,9 @@ AccessibilityTest.define('CrExtensionsErrorConsoleA11yTest', { ...@@ -225,7 +225,9 @@ AccessibilityTest.define('CrExtensionsErrorConsoleA11yTest', {
/** @override */ /** @override */
tests: { tests: {
'Accessible Error Console': function() { 'Accessible Error Console': function() {
assertTrue(!!document.querySelector('* /deep/ #errorsList')); assertTrue(!!document.querySelector('extensions-manager')
.$$('extensions-error-page')
.$$('#errorsList'));
}, },
}, },
}); });
...@@ -35,11 +35,6 @@ ...@@ -35,11 +35,6 @@
# Most of the a11y tests are failing because they use /deep/. Should be # Most of the a11y tests are failing because they use /deep/. Should be
# addressed as part of crbug.com/860069 # addressed as part of crbug.com/860069
-CrExtensionsA11yTest.*
-CrExtensionsA11yTestWithMultipleExensions.*
-CrExtensionsErrorConsoleA11yTest.*
-CrExtensionsShortcutA11yTestWithExtensions.*
-CrExtensionsShortcutA11yTestWithNoExtensions.*
-SettingsA11yManagePasswords.* -SettingsA11yManagePasswords.*
-SettingsA11ySignOut.* -SettingsA11ySignOut.*
-SettingsAccessibilityTest.* -SettingsAccessibilityTest.*
...@@ -135,8 +130,11 @@ CrElementsSliderTest.* ...@@ -135,8 +130,11 @@ CrElementsSliderTest.*
CrElementsToastTest.* CrElementsToastTest.*
CrElementsToggleTest.* CrElementsToggleTest.*
CrElementsToolbarSearchFieldTest.* CrElementsToolbarSearchFieldTest.*
CrExtensionsA11yTest.*
CrExtensionsA11yTestWithMultipleExensions.*
CrExtensionsCodeSectionTest.* CrExtensionsCodeSectionTest.*
CrExtensionsDetailViewTest.* CrExtensionsDetailViewTest.*
CrExtensionsErrorConsoleA11yTest.*
CrExtensionsErrorConsoleTest.* CrExtensionsErrorConsoleTest.*
CrExtensionsErrorPageTest.* CrExtensionsErrorPageTest.*
CrExtensionsItemListTest.* CrExtensionsItemListTest.*
...@@ -149,6 +147,8 @@ CrExtensionsOptionsDialogTest.* ...@@ -149,6 +147,8 @@ CrExtensionsOptionsDialogTest.*
CrExtensionsPackDialogTest.* CrExtensionsPackDialogTest.*
CrExtensionsRuntimeHostPermissionsTest.* CrExtensionsRuntimeHostPermissionsTest.*
CrExtensionsRuntimeHostsDialogTest.* CrExtensionsRuntimeHostsDialogTest.*
CrExtensionsShortcutA11yTestWithExtensions.*
CrExtensionsShortcutA11yTestWithNoExtensions.*
CrExtensionsShortcutInputTest.* CrExtensionsShortcutInputTest.*
CrExtensionsShortcutTest.* CrExtensionsShortcutTest.*
CrExtensionsSidebarTest.* CrExtensionsSidebarTest.*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment