Commit e98aa3c0 authored by Rune Lillesveen's avatar Rune Lillesveen Committed by Commit Bot

Remove outdated FIXME.

The FIXME comment does not make sense with the current state of the
code.

Change-Id: Ia13d8de2d2b09b4bfaf5ae353c8fb439cb8e40cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840831
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702837}
parent 2f3ce204
......@@ -2765,17 +2765,6 @@ void Document::UpdateStyleAndLayoutTree() {
UpdateActiveStyle();
UpdateStyleInvalidationIfNeeded();
// FIXME: We should update style on our ancestor chain before proceeding
// however doing so currently causes several tests to crash, as
// LocalFrame::setDocument calls Document::attach before setting the
// LocalDOMWindow on the LocalFrame, or the SecurityOrigin on the
// document. The attach, in turn resolves style (here) and then when we
// resolve style on the parent chain, we may end up re-attaching our
// containing iframe, which when asked HTMLFrameElementBase::isURLAllowed hits
// a null-dereference due to security code always assuming the document has a
// SecurityOrigin.
UpdateStyle();
NotifyLayoutTreeOfSubtreeChanges();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment