Commit e99e405c authored by Mike Dougherty's avatar Mike Dougherty Committed by Commit Bot

Rename |CRWWebStateObserver webState:navigationItemsPrunedCount:|

To adhere to Coding Guidelines for Cocoa, rename this method to
|webState:didPruneNavigationItemsWithCount:|.

Bug: 
Change-Id: Ibc07ab7012e1490b03e2e5ff814270ce4186ab11
Reviewed-on: https://chromium-review.googlesource.com/531464Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478822}
parent 53da5809
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
// Test implementation of CRWWebStateObserver protocol. // Test implementation of CRWWebStateObserver protocol.
@interface CRWTestWebStateObserver : NSObject<CRWWebStateObserver> @interface CRWTestWebStateObserver : NSObject<CRWWebStateObserver>
// Arguments passed to |webState:navigationItemsPrunedCount:|. // Arguments passed to |webState:didPruneNavigationItemsWithCount:|.
@property(nonatomic, readonly) @property(nonatomic, readonly)
web::TestNavigationItemsPrunedInfo* navigationItemsPrunedInfo; web::TestNavigationItemsPrunedInfo* navigationItemsPrunedInfo;
// Arguments passed to |webState:didStartNavigation:|. // Arguments passed to |webState:didStartNavigation:|.
......
...@@ -23,7 +23,7 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() = ...@@ -23,7 +23,7 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
} }
@implementation CRWTestWebStateObserver { @implementation CRWTestWebStateObserver {
// Arguments passed to |webState:navigationItemsPrunedCount:|. // Arguments passed to |webState:didPruneNavigationItemsWithCount:|.
std::unique_ptr<web::TestNavigationItemsPrunedInfo> std::unique_ptr<web::TestNavigationItemsPrunedInfo>
_navigationItemsPrunedInfo; _navigationItemsPrunedInfo;
// Arguments passed to |webState:didStartNavigation:|. // Arguments passed to |webState:didStartNavigation:|.
...@@ -137,7 +137,7 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() = ...@@ -137,7 +137,7 @@ TestUpdateFaviconUrlCandidatesInfo::~TestUpdateFaviconUrlCandidatesInfo() =
#pragma mark CRWWebStateObserver methods - #pragma mark CRWWebStateObserver methods -
- (void)webState:(web::WebState*)webState - (void)webState:(web::WebState*)webState
navigationItemsPrunedCount:(size_t)pruned_item_count { didPruneNavigationItemsWithCount:(size_t)pruned_item_count {
_navigationItemsPrunedInfo = _navigationItemsPrunedInfo =
base::MakeUnique<web::TestNavigationItemsPrunedInfo>(); base::MakeUnique<web::TestNavigationItemsPrunedInfo>();
_navigationItemsPrunedInfo->web_state = webState; _navigationItemsPrunedInfo->web_state = webState;
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
// Invoked by WebStateObserverBridge::NavigationItemsPruned. // Invoked by WebStateObserverBridge::NavigationItemsPruned.
- (void)webState:(web::WebState*)webState - (void)webState:(web::WebState*)webState
navigationItemsPrunedCount:(size_t)pruned_item_count; didPruneNavigationItemsWithCount:(size_t)pruned_item_count;
// Invoked by WebStateObserverBridge::NavigationItemCommitted. // Invoked by WebStateObserverBridge::NavigationItemCommitted.
- (void)webState:(web::WebState*)webState - (void)webState:(web::WebState*)webState
......
...@@ -15,10 +15,10 @@ WebStateObserverBridge::~WebStateObserverBridge() { ...@@ -15,10 +15,10 @@ WebStateObserverBridge::~WebStateObserverBridge() {
} }
void WebStateObserverBridge::NavigationItemsPruned(size_t pruned_item_count) { void WebStateObserverBridge::NavigationItemsPruned(size_t pruned_item_count) {
SEL selector = @selector(webState:navigationItemsPrunedCount:); SEL selector = @selector(webState:didPruneNavigationItemsWithCount:);
if ([observer_ respondsToSelector:selector]) { if ([observer_ respondsToSelector:selector]) {
[observer_ webState:web_state() [observer_ webState:web_state()
navigationItemsPrunedCount:pruned_item_count]; didPruneNavigationItemsWithCount:pruned_item_count];
} }
} }
......
...@@ -38,7 +38,7 @@ class WebStateObserverBridgeTest : public PlatformTest { ...@@ -38,7 +38,7 @@ class WebStateObserverBridgeTest : public PlatformTest {
scoped_refptr<net::HttpResponseHeaders> response_headers_; scoped_refptr<net::HttpResponseHeaders> response_headers_;
}; };
// Tests |webState:navigationItemsPrunedCount:| forwarding. // Tests |webState:didPruneNavigationItemsWithCount:| forwarding.
TEST_F(WebStateObserverBridgeTest, NavigationItemsPruned) { TEST_F(WebStateObserverBridgeTest, NavigationItemsPruned) {
ASSERT_FALSE([observer_ navigationItemsPrunedInfo]); ASSERT_FALSE([observer_ navigationItemsPrunedInfo]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment