Commit e9b529ee authored by kbr's avatar kbr Committed by Commit bot

Suppress two WebGL conformance failures on Mac 10.9 with Intel HD 3000 GPU.

Required exposing new Mac versions to Telemetry's test expectations.
Added unit test.

BUG=417415

Review URL: https://codereview.chromium.org/597383002

Cr-Commit-Position: refs/heads/master@{#296634}
parent 59a0e353
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations as expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
......
...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations ...@@ -8,7 +8,7 @@ from telemetry.page import test_expectations
# #
# Operating systems: # Operating systems:
# win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion, # win, xp, vista, win7, mac, leopard, snowleopard, lion, mountainlion,
# linux, chromeos, android # mavericks, yosemite, linux, chromeos, android
# #
# GPU vendors: # GPU vendors:
# amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm, # amd, arm, broadcom, hisilicon, intel, imagination, nvidia, qualcomm,
...@@ -76,6 +76,12 @@ class WebGLConformanceExpectations(test_expectations.TestExpectations): ...@@ -76,6 +76,12 @@ class WebGLConformanceExpectations(test_expectations.TestExpectations):
self.Fail('conformance/ogles/GL/operators/operators_009_to_016.html', self.Fail('conformance/ogles/GL/operators/operators_009_to_016.html',
['mountainlion', ('intel', 0x116)], bug=322795) ['mountainlion', ('intel', 0x116)], bug=322795)
# Mac 10.9 / Intel HD 3000 failures
self.Fail('conformance/ogles/GL/operators/operators_009_to_016.html',
['mavericks', ('intel', 0x116)], bug=417415)
self.Fail('conformance/rendering/gl-scissor-test.html',
['mavericks', ('intel', 0x116)], bug=417415)
# Mac Retina failures # Mac Retina failures
self.Fail( self.Fail(
'conformance/glsl/bugs/array-of-struct-with-int-first-position.html', 'conformance/glsl/bugs/array-of-struct-with-int-first-position.html',
......
...@@ -6,7 +6,7 @@ import fnmatch ...@@ -6,7 +6,7 @@ import fnmatch
OS_MODIFIERS = ['win', 'xp', 'vista', 'win7', OS_MODIFIERS = ['win', 'xp', 'vista', 'win7',
'mac', 'leopard', 'snowleopard', 'lion', 'mountainlion', 'mac', 'leopard', 'snowleopard', 'lion', 'mountainlion',
'linux', 'chromeos', 'android'] 'mavericks', 'yosemite', 'linux', 'chromeos', 'android']
GPU_MODIFIERS = ['amd', 'arm', 'broadcom', 'hisilicon', 'intel', 'imagination', GPU_MODIFIERS = ['amd', 'arm', 'broadcom', 'hisilicon', 'intel', 'imagination',
'nvidia', 'qualcomm', 'vivante'] 'nvidia', 'qualcomm', 'vivante']
CONFIG_MODIFIERS = ['debug', 'release'] CONFIG_MODIFIERS = ['debug', 'release']
......
...@@ -59,6 +59,9 @@ class SampleTestExpectations(test_expectations.TestExpectations): ...@@ -59,6 +59,9 @@ class SampleTestExpectations(test_expectations.TestExpectations):
self.Fail('page9.html', ['imagination']) self.Fail('page9.html', ['imagination'])
self.Fail('page10.html', [('imagination', 'PowerVR SGX 554')]) self.Fail('page10.html', [('imagination', 'PowerVR SGX 554')])
self.Fail('Pages.page_11') self.Fail('Pages.page_11')
self.Fail('page12.html', ['mountainlion'])
self.Fail('page13.html', ['mavericks'])
self.Fail('page14.html', ['yosemite'])
class TestExpectationsTest(unittest.TestCase): class TestExpectationsTest(unittest.TestCase):
def setUp(self): def setUp(self):
...@@ -189,3 +192,30 @@ class TestExpectationsTest(unittest.TestCase): ...@@ -189,3 +192,30 @@ class TestExpectationsTest(unittest.TestCase):
page = page_module.Page('http://test.com/page11.html', ps, page = page_module.Page('http://test.com/page11.html', ps,
name='Pages.page_11') name='Pages.page_11')
self.assertExpectationEquals('fail', page) self.assertExpectationEquals('fail', page)
# Verify version-specific Mac expectations.
def testMacVersionExpectations(self):
ps = page_set.PageSet()
page = page_module.Page('http://test.com/page12.html', ps)
self.assertExpectationEquals('fail', page,
StubPlatform('mac', 'mountainlion'))
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'mavericks'))
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'yosemite'))
ps = page_set.PageSet()
page = page_module.Page('http://test.com/page13.html', ps)
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'mountainlion'))
self.assertExpectationEquals('fail', page,
StubPlatform('mac', 'mavericks'))
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'yosemite'))
ps = page_set.PageSet()
page = page_module.Page('http://test.com/page14.html', ps)
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'mountainlion'))
self.assertExpectationEquals('pass', page,
StubPlatform('mac', 'mavericks'))
self.assertExpectationEquals('fail', page,
StubPlatform('mac', 'yosemite'))
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment