Commit e9b5b7fb authored by Donn Denman's avatar Donn Denman Committed by Commit Bot

[TTS] And Unity integration about:flag feature.

Adds a new Feature for integration with Unified Consent.
When this is enabled, and unified consent is on, the TTS
opt-in promo will not be needed.  We'll implement a follow-on
CL that does the conditional disabling off of this flag.

BUG=825428

Change-Id: I4becefb6bf3d1862f941bccd85c2bbc863cb99d4
Reviewed-on: https://chromium-review.googlesource.com/1148689Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577708}
parent 67493d01
...@@ -189,6 +189,8 @@ public abstract class ChromeFeatureList { ...@@ -189,6 +189,8 @@ public abstract class ChromeFeatureList {
public static final String CONTEXTUAL_SEARCH_SECOND_TAP = "ContextualSearchSecondTap"; public static final String CONTEXTUAL_SEARCH_SECOND_TAP = "ContextualSearchSecondTap";
public static final String CONTEXTUAL_SEARCH_TAP_DISABLE_OVERRIDE = public static final String CONTEXTUAL_SEARCH_TAP_DISABLE_OVERRIDE =
"ContextualSearchTapDisableOverride"; "ContextualSearchTapDisableOverride";
public static final String CONTEXTUAL_SEARCH_UNITY_INTEGRATION =
"ContextualSearchUnityIntegration";
public static final String CONTEXTUAL_SUGGESTIONS_BOTTOM_SHEET = public static final String CONTEXTUAL_SUGGESTIONS_BOTTOM_SHEET =
"ContextualSuggestionsBottomSheet"; "ContextualSuggestionsBottomSheet";
public static final String CONTEXTUAL_SUGGESTIONS_BUTTON = "ContextualSuggestionsButton"; public static final String CONTEXTUAL_SUGGESTIONS_BUTTON = "ContextualSuggestionsButton";
......
...@@ -1349,6 +1349,11 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -1349,6 +1349,11 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kContextualSearchSecondTapName, flag_descriptions::kContextualSearchSecondTapName,
flag_descriptions::kContextualSearchSecondTapDescription, kOsAndroid, flag_descriptions::kContextualSearchSecondTapDescription, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kContextualSearchSecondTap)}, FEATURE_VALUE_TYPE(chrome::android::kContextualSearchSecondTap)},
{"contextual-search-unity-integration",
flag_descriptions::kContextualSearchUnityIntegrationName,
flag_descriptions::kContextualSearchUnityIntegrationDescription,
kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kContextualSearchUnityIntegration)},
{"explore-sites", flag_descriptions::kExploreSitesName, {"explore-sites", flag_descriptions::kExploreSitesName,
flag_descriptions::kExploreSitesDescription, kOsAndroid, flag_descriptions::kExploreSitesDescription, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kExploreSites)}, FEATURE_VALUE_TYPE(chrome::android::kExploreSites)},
......
...@@ -93,6 +93,7 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -93,6 +93,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&kContextualSearchMlTapSuppression, &kContextualSearchMlTapSuppression,
&kContextualSearchSecondTap, &kContextualSearchSecondTap,
&kContextualSearchTapDisableOverride, &kContextualSearchTapDisableOverride,
&kContextualSearchUnityIntegration,
&kCustomContextMenu, &kCustomContextMenu,
&kCustomFeedbackUi, &kCustomFeedbackUi,
&kDontPrefetchLibraries, &kDontPrefetchLibraries,
...@@ -257,6 +258,9 @@ const base::Feature kContextualSearchSecondTap{ ...@@ -257,6 +258,9 @@ const base::Feature kContextualSearchSecondTap{
const base::Feature kContextualSearchTapDisableOverride{ const base::Feature kContextualSearchTapDisableOverride{
"ContextualSearchTapDisableOverride", base::FEATURE_DISABLED_BY_DEFAULT}; "ContextualSearchTapDisableOverride", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kContextualSearchUnityIntegration{
"ContextualSearchUnityIntegration", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kCustomContextMenu{"CustomContextMenu", const base::Feature kCustomContextMenu{"CustomContextMenu",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
......
...@@ -39,6 +39,7 @@ extern const base::Feature kContentSuggestionsThumbnailDominantColor; ...@@ -39,6 +39,7 @@ extern const base::Feature kContentSuggestionsThumbnailDominantColor;
extern const base::Feature kContextualSearchMlTapSuppression; extern const base::Feature kContextualSearchMlTapSuppression;
extern const base::Feature kContextualSearchSecondTap; extern const base::Feature kContextualSearchSecondTap;
extern const base::Feature kContextualSearchTapDisableOverride; extern const base::Feature kContextualSearchTapDisableOverride;
extern const base::Feature kContextualSearchUnityIntegration;
extern const base::Feature kCustomContextMenu; extern const base::Feature kCustomContextMenu;
extern const base::Feature kCustomFeedbackUi; extern const base::Feature kCustomFeedbackUi;
extern const base::Feature kDontPrefetchLibraries; extern const base::Feature kDontPrefetchLibraries;
......
...@@ -2227,6 +2227,11 @@ const char kContextualSearchSecondTapDescription[] = ...@@ -2227,6 +2227,11 @@ const char kContextualSearchSecondTapDescription[] =
"Enables triggering on a second tap gesture even when Ranker would " "Enables triggering on a second tap gesture even when Ranker would "
"normally suppress that tap."; "normally suppress that tap.";
const char kContextualSearchUnityIntegrationName[] =
"Contextual Search integration with Unified Consent";
const char kContextualSearchUnityIntegrationDescription[] =
"Enables integration of Tap to Search with Unified Consent.";
const char kExploreSitesName[] = "Explore websites"; const char kExploreSitesName[] = "Explore websites";
const char kExploreSitesDescription[] = const char kExploreSitesDescription[] =
"Enables portal from new tab page to explore websites."; "Enables portal from new tab page to explore websites.";
......
...@@ -1352,6 +1352,9 @@ extern const char kContextualSearchRankerQueryDescription[]; ...@@ -1352,6 +1352,9 @@ extern const char kContextualSearchRankerQueryDescription[];
extern const char kContextualSearchSecondTapName[]; extern const char kContextualSearchSecondTapName[];
extern const char kContextualSearchSecondTapDescription[]; extern const char kContextualSearchSecondTapDescription[];
extern const char kContextualSearchUnityIntegrationName[];
extern const char kContextualSearchUnityIntegrationDescription[];
extern const char kExploreSitesName[]; extern const char kExploreSitesName[];
extern const char kExploreSitesDescription[]; extern const char kExploreSitesDescription[];
......
...@@ -27724,6 +27724,7 @@ from previous Chrome versions. ...@@ -27724,6 +27724,7 @@ from previous Chrome versions.
<int value="-1596559650" label="max-tiles-for-interest-area"/> <int value="-1596559650" label="max-tiles-for-interest-area"/>
<int value="-1594298767" label="FullscreenToolbarReveal:enabled"/> <int value="-1594298767" label="FullscreenToolbarReveal:enabled"/>
<int value="-1586642651" label="MaterialDesignExtensions:disabled"/> <int value="-1586642651" label="MaterialDesignExtensions:disabled"/>
<int value="-1585733447" label="ContextualSearchUnityIntegration:disabled"/>
<int value="-1584944853" label="TrilinearFiltering:enabled"/> <int value="-1584944853" label="TrilinearFiltering:enabled"/>
<int value="-1584499823" label="EnableZeroStateSuggestions:enabled"/> <int value="-1584499823" label="EnableZeroStateSuggestions:enabled"/>
<int value="-1583728573" label="AutofillCreditCardSigninPromo:disabled"/> <int value="-1583728573" label="AutofillCreditCardSigninPromo:disabled"/>
...@@ -29145,6 +29146,7 @@ from previous Chrome versions. ...@@ -29145,6 +29146,7 @@ from previous Chrome versions.
<int value="1338864675" label="EnableTouchableAppContextMenu:disabled"/> <int value="1338864675" label="EnableTouchableAppContextMenu:disabled"/>
<int value="1339426771" label="TopSitesFromSiteEngagement:disabled"/> <int value="1339426771" label="TopSitesFromSiteEngagement:disabled"/>
<int value="1340690624" label="WebPaymentsMethodSectionOrderV2:disabled"/> <int value="1340690624" label="WebPaymentsMethodSectionOrderV2:disabled"/>
<int value="1343050930" label="ContextualSearchUnityIntegration:enabled"/>
<int value="1343516821" label="ignore-previews-blocklist"/> <int value="1343516821" label="ignore-previews-blocklist"/>
<int value="1344833841" label="ImeThread:enabled"/> <int value="1344833841" label="ImeThread:enabled"/>
<int value="1351830811" label="do-not-ignore-autocomplete-off"/> <int value="1351830811" label="do-not-ignore-autocomplete-off"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment