Commit e9c7c377 authored by mad@chromium.org's avatar mad@chromium.org

Adding basic Metro Print Metrics.

BUG=136041
TEST=Make sure metro print actions are logged as histograms.


Review URL: https://chromiumcodereview.appspot.com/10831272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151285 0039d316-1c4b-4281-b951-d872f2087c98
parent 540e3e9c
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/lazy_instance.h" #include "base/lazy_instance.h"
#include "base/memory/scoped_ptr.h" #include "base/memory/scoped_ptr.h"
#include "base/metrics/histogram.h"
#include "base/timer.h" #include "base/timer.h"
#include "base/utf_string_conversions.h" #include "base/utf_string_conversions.h"
#include "chrome/browser/browser_process.h" #include "chrome/browser/browser_process.h"
...@@ -109,6 +110,9 @@ bool PrintViewManager::AdvancedPrintNow() { ...@@ -109,6 +110,9 @@ bool PrintViewManager::AdvancedPrintNow() {
} }
bool PrintViewManager::PrintToDestination() { bool PrintViewManager::PrintToDestination() {
// TODO(mad): Remove this once we can send user metrics from the metro driver.
// crbug.com/142330
UMA_HISTOGRAM_ENUMERATION("Metro.Print", 0, 2);
// TODO(mad): Use a passed in destination interface instead. // TODO(mad): Use a passed in destination interface instead.
g_browser_process->print_job_manager()->SetPrintDestination( g_browser_process->print_job_manager()->SetPrintDestination(
printing::CreatePrintDestination()); printing::CreatePrintDestination());
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "base/i18n/file_util_icu.h" #include "base/i18n/file_util_icu.h"
#include "base/i18n/time_formatting.h" #include "base/i18n/time_formatting.h"
#include "base/message_loop.h" #include "base/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/time.h" #include "base/time.h"
#include "base/utf_string_conversions.h" #include "base/utf_string_conversions.h"
#include "base/values.h" #include "base/values.h"
...@@ -230,8 +231,12 @@ void PrintingContextWin::AskUserForSettings( ...@@ -230,8 +231,12 @@ void PrintingContextWin::AskUserForSettings(
MetroShowPrintUI metro_show_print_ui = MetroShowPrintUI metro_show_print_ui =
reinterpret_cast<MetroShowPrintUI>( reinterpret_cast<MetroShowPrintUI>(
::GetProcAddress(metro_module, "MetroShowPrintUI")); ::GetProcAddress(metro_module, "MetroShowPrintUI"));
if (metro_show_print_ui) if (metro_show_print_ui) {
// TODO(mad): Remove this once we can send user metrics from the metro
// driver. crbug.com/142330
UMA_HISTOGRAM_ENUMERATION("Metro.Print", 1, 2);
metro_show_print_ui(); metro_show_print_ui();
}
} }
return callback.Run(CANCEL); return callback.Run(CANCEL);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment