Commit e9d22e0f authored by hichris123's avatar hichris123 Committed by Commit bot

Re-enable HttpSecurityHeadersTest.UpdateDynamicPKPMaxAge0

This test was disabled on Windows due to flakiness. I ran it locally & on the try jobs, and neither gave any flakes, therefore, this CL re-enables the test.

BUG=375538

Review URL: https://codereview.chromium.org/948733002

Cr-Commit-Position: refs/heads/master@{#318177}
parent 7f4aed4a
...@@ -593,13 +593,7 @@ TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPOnly) { ...@@ -593,13 +593,7 @@ TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPOnly) {
EXPECT_NE(new_dynamic_domain_state.pkp.spki_hashes.end(), hash); EXPECT_NE(new_dynamic_domain_state.pkp.spki_hashes.end(), hash);
} }
// Failing on win_chromium_rel. crbug.com/375538 TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPMaxAge0) {
#if defined(OS_WIN)
#define MAYBE_UpdateDynamicPKPMaxAge0 DISABLED_UpdateDynamicPKPMaxAge0
#else
#define MAYBE_UpdateDynamicPKPMaxAge0 UpdateDynamicPKPMaxAge0
#endif
TEST_F(HttpSecurityHeadersTest, MAYBE_UpdateDynamicPKPMaxAge0) {
TransportSecurityState state; TransportSecurityState state;
TransportSecurityState::DomainState static_domain_state; TransportSecurityState::DomainState static_domain_state;
...@@ -677,7 +671,6 @@ TEST_F(HttpSecurityHeadersTest, MAYBE_UpdateDynamicPKPMaxAge0) { ...@@ -677,7 +671,6 @@ TEST_F(HttpSecurityHeadersTest, MAYBE_UpdateDynamicPKPMaxAge0) {
&failure_log)); &failure_log));
EXPECT_NE(0UL, failure_log.length()); EXPECT_NE(0UL, failure_log.length());
} }
#undef MAYBE_UpdateDynamicPKPMaxAge0
// Tests that when a static HSTS and a static HPKP entry are present, adding a // Tests that when a static HSTS and a static HPKP entry are present, adding a
// dynamic HSTS header does not clobber the static HPKP entry. Further, adding a // dynamic HSTS header does not clobber the static HPKP entry. Further, adding a
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment