Commit e9e6169a authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

Binding: Make blink_python_runner more flexible

Before this CL, a GN wrapper "blink_python_runner" assumed its invoker
to have inputs, outputs, and deps.

This CL makes it more flexible, i.e. to assume invoker's sources, data,
and data_deps.
This change resolves the confusing situation, for example, having |data| in
an invoker does not affect on any actions.


Bug: 839389
Change-Id: Ieecb8d07adc7f020df7de869fd15789d76c81621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718065
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Auto-Submit: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681211}
parent dabc0b61
......@@ -96,11 +96,17 @@ make_core_generated_deps = [
template("blink_python_runner") {
action(target_name) {
script = "$_scripts_dir/run_with_pythonpath.py"
inputs = [
sources = [
invoker.script,
]
if (defined(invoker.sources)) {
sources += invoker.sources
}
if (defined(invoker.inputs)) {
inputs += invoker.inputs
inputs = invoker.inputs
}
if (defined(invoker.data)) {
data = invoker.data
}
outputs = invoker.outputs
args = [
......@@ -115,6 +121,9 @@ template("blink_python_runner") {
if (defined(invoker.deps)) {
deps = invoker.deps
}
if (defined(invoker.data_deps)) {
data_deps = invoker.data_deps
}
forward_variables_from(invoker, [ "visibility" ])
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment