Allow blink.console or webkit.console in telemetry

This is in preparation of me renaming the "webkit*" category to "blink*"
in the blink codebase. Once that change has rolled into chromium I'll do
another CL for chromium to remove the "webkit.console" entry.

BUG=386847

Review URL: https://codereview.chromium.org/342993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278700 0039d316-1c4b-4281-b951-d872f2087c98
parent 0e37fc20
...@@ -83,7 +83,9 @@ class _MemoryValidator(page_test.PageTest): ...@@ -83,7 +83,9 @@ class _MemoryValidator(page_test.PageTest):
'--force-gpu-mem-available-mb=%s' % MEMORY_LIMIT_MB) '--force-gpu-mem-available-mb=%s' % MEMORY_LIMIT_MB)
def WillNavigateToPage(self, page, tab): def WillNavigateToPage(self, page, tab):
custom_categories = ['webkit.console', 'gpu'] # FIXME: Remove webkit.console when blink.console lands in chromium and the
# ref builds are updated. crbug.com/386847
custom_categories = ['webkit.console', 'blink.console', 'gpu']
tab.browser.StartTracing(','.join(custom_categories), 60) tab.browser.StartTracing(','.join(custom_categories), 60)
def _FormatException(self, low_or_high, mb_used): def _FormatException(self, low_or_high, mb_used):
......
...@@ -27,8 +27,11 @@ class ImageDecoding(page_measurement.PageMeasurement): ...@@ -27,8 +27,11 @@ class ImageDecoding(page_measurement.PageMeasurement):
self._power_metric.Start(page, tab) self._power_metric.Start(page, tab)
# FIXME: bare 'devtools' is for compatibility with older reference versions # FIXME: bare 'devtools' is for compatibility with older reference versions
# only and may eventually be removed. # only and may eventually be removed.
# FIXME: Remove webkit.console when blink.console lands in chromium and
# the ref builds are updated. crbug.com/386847
tab.browser.StartTracing( tab.browser.StartTracing(
'disabled-by-default-devtools.timeline*,devtools,webkit.console') 'disabled-by-default-devtools.timeline*,' +
'devtools,webkit.console,blink.console')
def StopBrowserAfterPage(self, browser, page): def StopBrowserAfterPage(self, browser, page):
return not browser.tabs[0].ExecuteJavaScript(""" return not browser.tabs[0].ExecuteJavaScript("""
......
...@@ -26,7 +26,9 @@ class SmoothnessController(object): ...@@ -26,7 +26,9 @@ class SmoothnessController(object):
self._interaction = None self._interaction = None
def Start(self, page, tab): def Start(self, page, tab):
custom_categories = ['webkit.console', 'benchmark'] # FIXME: Remove webkit.console when blink.console lands in chromium and
# the ref builds are updated. crbug.com/386847
custom_categories = ['webkit.console', 'blink.console', 'benchmark']
custom_categories += page.GetSyntheticDelayCategories() custom_categories += page.GetSyntheticDelayCategories()
tab.browser.StartTracing(','.join(custom_categories), 60) tab.browser.StartTracing(','.join(custom_categories), 60)
if tab.browser.platform.IsRawDisplayFrameRateSupported(): if tab.browser.platform.IsRawDisplayFrameRateSupported():
......
...@@ -68,11 +68,16 @@ class SmoothnessUnitTest( ...@@ -68,11 +68,16 @@ class SmoothnessUnitTest(
'DELAY(cc.BeginMainFrame;0.012000;static)', 'DELAY(cc.BeginMainFrame;0.012000;static)',
'DELAY(cc.DrawAndSwap;0.012000;alternating)', 'DELAY(cc.DrawAndSwap;0.012000;alternating)',
'DELAY(gpu.PresentingFrame;0.012000;static)', 'DELAY(gpu.PresentingFrame;0.012000;static)',
'benchmark', 'benchmark'
'webkit.console'
] ]
actual_category_filter = tab.browser.category_filter.split(',') actual_category_filter = tab.browser.category_filter.split(',')
actual_category_filter.sort() actual_category_filter.sort()
# FIXME: Put blink.console into the expected above and remove these two
# remove entries when the blink.console change has rolled into chromium.
actual_category_filter.remove('webkit.console')
actual_category_filter.remove('blink.console')
if expected_category_filter != actual_category_filter: if expected_category_filter != actual_category_filter:
sys.stderr.write("Expected category filter: %s\n" % sys.stderr.write("Expected category filter: %s\n" %
repr(expected_category_filter)) repr(expected_category_filter))
......
...@@ -15,9 +15,12 @@ DEFAULT_TRACE_CATEGORIES = None ...@@ -15,9 +15,12 @@ DEFAULT_TRACE_CATEGORIES = None
# Categories for absolute minimum overhead tracing. This contains no # Categories for absolute minimum overhead tracing. This contains no
# sub-traces of thread tasks, so it's only useful for capturing the # sub-traces of thread tasks, so it's only useful for capturing the
# cpu-time spent on threads (as well as needed benchmark traces) # cpu-time spent on threads (as well as needed benchmark traces)
# FIXME: Remove webkit.console when blink.console lands in chromium and
# the ref builds are updated. crbug.com/386847
MINIMAL_TRACE_CATEGORIES = ("toplevel," MINIMAL_TRACE_CATEGORIES = ("toplevel,"
"benchmark," "benchmark,"
"webkit.console," "webkit.console,"
"blink.console,"
"trace_event_overhead") "trace_event_overhead")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment