Commit ea2f8723 authored by Sunny Sachanandani's avatar Sunny Sachanandani Committed by Commit Bot

Reland "Enable Windows NV12 overlays on waterfall"

This is a reland of 2be1f912

In addition to the original change, also temporarily mark video pixel
tests on the Intel HD630 bot as failing, and increment the test version
numbers for rebaselining. A follow-up CL will re-enable the tests.

Original change's description:
> Enable Windows NV12 overlays on waterfall
>
> We plan on shipping this via a finch experiment to Canary/Dev soon, and then
> enable it by default if we don't encounter major issues. This should only affect
> the DirectComposition pixel tests since we force-enable overlays for those
> tests. Other tests don't exercise DirectComposition code because those code
> paths are disabled unless the hardware supports it.
>
> Bug: 869677
> Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a
> Reviewed-on: https://chromium-review.googlesource.com/1170385
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582305}

TBR=holte@chromium.org

Bug: 869677
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8fda27e0377f4cd8ad38c96bf8441832c3644436
Reviewed-on: https://chromium-review.googlesource.com/1182222
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585351}
parent e774f211
...@@ -62,8 +62,15 @@ class PixelExpectations(GpuTestExpectations): ...@@ -62,8 +62,15 @@ class PixelExpectations(GpuTestExpectations):
# TODO(kbr): flakily timing out on this configuration. # TODO(kbr): flakily timing out on this configuration.
self.Flaky('*', ['linux', 'intel', 'debug'], bug=648369) self.Flaky('*', ['linux', 'intel', 'debug'], bug=648369)
self.Flaky('Pixel_Video_MP4', ['android', 'nvidia'], bug=716564) # TODO(sunnyps): re-enable after rebaselining
self.Flaky('Pixel_Video_MP4', ['linux', 'nvidia'], bug=819635) # self.Flaky('Pixel_Video_MP4', ['android', 'nvidia'], bug=716564)
# self.Flaky('Pixel_Video_MP4', ['linux', 'nvidia'], bug=819635)
# TODO(sunnyps): temporarily disabling for rebaselining.
self.Fail('Pixel_Video_MP4', bug=869677)
self.Fail('Pixel_Video_VP9', bug=869677)
self.Fail('Pixel_DirectComposition_Video_MP4', bug=869677)
self.Fail('Pixel_DirectComposition_Video_VP9', bug=869677)
# TODO(junov): rebaselining # TODO(junov): rebaselining
self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing', self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing',
...@@ -86,10 +93,11 @@ class PixelExpectations(GpuTestExpectations): ...@@ -86,10 +93,11 @@ class PixelExpectations(GpuTestExpectations):
['android', ('qualcomm', 'Adreno (TM) 330')], bug=773293) ['android', ('qualcomm', 'Adreno (TM) 330')], bug=773293)
# Failing on Mac Intel HighSierra # Failing on Mac Intel HighSierra
self.Fail('Pixel_Video_MP4', # TODO(sunnyps): re-enable after rebaselining.
['highsierra', ('intel', 0xa2e)], bug=774809) # self.Fail('Pixel_Video_MP4',
self.Fail('Pixel_Video_VP9', # ['highsierra', ('intel', 0xa2e)], bug=774809)
['highsierra', ('intel', 0xa2e)], bug=774809) # self.Fail('Pixel_Video_VP9',
# ['highsierra', ('intel', 0xa2e)], bug=774809)
self.Fail('Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha', self.Fail('Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha',
['highsierra', ('intel', 0xa2e)], bug=774809) ['highsierra', ('intel', 0xa2e)], bug=774809)
self.Flaky('Pixel_OffscreenCanvasTransferBeforeStyleResize', self.Flaky('Pixel_OffscreenCanvasTransferBeforeStyleResize',
...@@ -118,7 +126,8 @@ class PixelExpectations(GpuTestExpectations): ...@@ -118,7 +126,8 @@ class PixelExpectations(GpuTestExpectations):
self.Fail('Pixel_WebGLSadCanvas', ['android'], bug=575305) self.Fail('Pixel_WebGLSadCanvas', ['android'], bug=575305)
# Flaky on Android: crbug.com/860548 # Flaky on Android: crbug.com/860548
self.Flaky('Pixel_Video_VP9', ['android'], bug=860548) # TODO(sunnyps): re-enable after rebaselining.
# self.Flaky('Pixel_Video_VP9', ['android'], bug=860548)
self.Fail('Pixel_CanvasLowLatencyWebGL', ['android', 'nvidia'], bug=868596) self.Fail('Pixel_CanvasLowLatencyWebGL', ['android', 'nvidia'], bug=868596)
self.Fail('Pixel_OffscreenCanvasWebGLPaintAfterResize', self.Fail('Pixel_OffscreenCanvasWebGLPaintAfterResize',
......
...@@ -192,13 +192,13 @@ def DefaultPages(base_name): ...@@ -192,13 +192,13 @@ def DefaultPages(base_name):
'pixel_video_mp4.html', 'pixel_video_mp4.html',
base_name + '_Video_MP4', base_name + '_Video_MP4',
test_rect=[0, 0, 300, 300], test_rect=[0, 0, 300, 300],
revision=9), revision=10),
PixelTestPage( PixelTestPage(
'pixel_video_vp9.html', 'pixel_video_vp9.html',
base_name + '_Video_VP9', base_name + '_Video_VP9',
test_rect=[0, 0, 300, 300], test_rect=[0, 0, 300, 300],
revision=9), revision=10),
PixelTestPage( PixelTestPage(
'pixel_webgl_premultiplied_alpha_false.html', 'pixel_webgl_premultiplied_alpha_false.html',
...@@ -754,14 +754,14 @@ def DirectCompositionPages(base_name): ...@@ -754,14 +754,14 @@ def DirectCompositionPages(base_name):
'pixel_video_mp4.html', 'pixel_video_mp4.html',
base_name + '_DirectComposition_Video_MP4', base_name + '_DirectComposition_Video_MP4',
test_rect=[0, 0, 300, 300], test_rect=[0, 0, 300, 300],
revision=7, revision=8,
browser_args=browser_args), browser_args=browser_args),
PixelTestPage( PixelTestPage(
'pixel_video_vp9.html', 'pixel_video_vp9.html',
base_name + '_DirectComposition_Video_VP9', base_name + '_DirectComposition_Video_VP9',
test_rect=[0, 0, 300, 300], test_rect=[0, 0, 300, 300],
revision=9, revision=10,
browser_args=browser_args), browser_args=browser_args),
PixelTestPage( PixelTestPage(
......
...@@ -1422,6 +1422,21 @@ ...@@ -1422,6 +1422,21 @@
] ]
} }
], ],
"DirectCompositionPreferNV12Overlays": [
{
"platforms": [
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"DirectCompositionPreferNV12Overlays"
]
}
]
}
],
"DownloadHomeMoreButton": [ "DownloadHomeMoreButton": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment