Commit ea36b905 authored by Abhijeet Kandalkar's avatar Abhijeet Kandalkar Committed by Commit Bot

Use new downcast helpers for blink::SpinButtonElement

Bug: 891908
Change-Id: I2107c9975d3605a4937d4e6946d8ea716fab2789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652391
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668491}
parent aa871940
...@@ -102,16 +102,11 @@ class CORE_EXPORT SpinButtonElement final : public HTMLDivElement, ...@@ -102,16 +102,11 @@ class CORE_EXPORT SpinButtonElement final : public HTMLDivElement,
TaskRunnerTimer<SpinButtonElement> repeating_timer_; TaskRunnerTimer<SpinButtonElement> repeating_timer_;
}; };
DEFINE_TYPE_CASTS(SpinButtonElement,
Node,
node,
To<Element>(node)->IsSpinButtonElement(),
To<Element>(node).IsSpinButtonElement());
template <> template <>
struct DowncastTraits<SpinButtonElement> { struct DowncastTraits<SpinButtonElement> {
static bool AllowFrom(const Node& node) { static bool AllowFrom(const Node& node) {
return ToElement(node).IsSpinButtonElement(); auto* element = DynamicTo<Element>(node);
return element && element->IsSpinButtonElement();
} }
}; };
......
...@@ -378,7 +378,7 @@ bool LayoutTheme::IsSpinUpButtonPartPressed(const Node* node) { ...@@ -378,7 +378,7 @@ bool LayoutTheme::IsSpinUpButtonPartPressed(const Node* node) {
if (!node || !node->IsActive() || !node->IsElementNode() || if (!node || !node->IsActive() || !node->IsElementNode() ||
!ToElement(node)->IsSpinButtonElement()) !ToElement(node)->IsSpinButtonElement())
return false; return false;
const SpinButtonElement* element = ToSpinButtonElement(node); const auto* element = To<SpinButtonElement>(node);
return element->GetUpDownState() == SpinButtonElement::kUp; return element->GetUpDownState() == SpinButtonElement::kUp;
} }
...@@ -395,7 +395,7 @@ bool LayoutTheme::IsHovered(const Node* node) { ...@@ -395,7 +395,7 @@ bool LayoutTheme::IsHovered(const Node* node) {
return false; return false;
if (!node->IsElementNode() || !ToElement(node)->IsSpinButtonElement()) if (!node->IsElementNode() || !ToElement(node)->IsSpinButtonElement())
return node->IsHovered(); return node->IsHovered();
const SpinButtonElement* element = ToSpinButtonElement(node); const auto* element = To<SpinButtonElement>(node);
return element->IsHovered() && return element->IsHovered() &&
element->GetUpDownState() != SpinButtonElement::kIndeterminate; element->GetUpDownState() != SpinButtonElement::kIndeterminate;
} }
...@@ -404,7 +404,7 @@ bool LayoutTheme::IsSpinUpButtonPartHovered(const Node* node) { ...@@ -404,7 +404,7 @@ bool LayoutTheme::IsSpinUpButtonPartHovered(const Node* node) {
if (!node || !node->IsElementNode() || if (!node || !node->IsElementNode() ||
!ToElement(node)->IsSpinButtonElement()) !ToElement(node)->IsSpinButtonElement())
return false; return false;
const SpinButtonElement* element = ToSpinButtonElement(node); const auto* element = To<SpinButtonElement>(node);
return element->GetUpDownState() == SpinButtonElement::kUp; return element->GetUpDownState() == SpinButtonElement::kUp;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment