mac arm64: use the correct page size for this platform in PartitionAlloc
Apple CPUs since A9 use a 16kB physical page size, which is a change for macOS on arm64 relative to the 4kB pages used on x86_64. PartitionAlloc operates on pages directly, and must be aware of the larger pages on the new platform. If this same change were effective for macOS on x86_64, it would allow x86_64 Chrome to run under binary translation (Rosetta) on arm64. Doing so has potential observable impacts, including memory footprint and performance. Run-time page size detection could be used to overcome this, and would also provide insulation against future page size changes, but that’s a larger and more invasive change. It’s likely that we will adopt one of these strategies soon, but for now, this arm64-only change is sufficient to run Chrome on arm64 Macs. Bug: 1098899 Change-Id: I50b48728350b87a319433188306daad747741e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292831 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787452}
Showing
Please register or sign in to comment