Fix formAction return value for empty formaction content attribute.

According to the standard and web-platform-tests, empty attribute value should
return the document URL.
https://html.spec.whatwg.org/multipage/forms.html#dom-fs-formaction

> The formAction IDL attribute must reflect the formaction content attribute,
> except that on getting, when the content attribute is missing or its value is
> the empty string, the document's address must be returned instead.

This CL removes empty formaction tests in submit-form-attributes.html.
html/semantics/forms/attributes-common-to-form-controls/formaction*.html cover
them.

BUG=520835

Review URL: https://codereview.chromium.org/1321033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/TestExpectations

@@ -396,8 +396,6 @@ crbug.com/508725 imported/web-platform-tests/html/semantics/forms/textfieldselec
 crbug.com/490511 imported/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ ImageOnlyFailure ]
 crbug.com/490511 imported/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/src.html [ Failure ]
 crbug.com/526920 imported/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html [ Failure ]
-crbug.com/520835 imported/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/formAction_document_address.html [ Failure ]
-crbug.com/520835 imported/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/formaction.html [ Failure ]
 # script-for-event.html: We can't check in failure results because we also have
 # script-for-event.xhtml.
 crbug.com/520844 imported/web-platform-tests/html/semantics/scripting-1/the-script-element/script-for-event.html [ Failure ]

third_party/WebKit/LayoutTests/fast/forms/submit-form-attributes-expected.txt

@@ -4,7 +4,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
 Ordinary values for input:
-PASS input.formAction is ""
 PASS input.formEnctype is ""
 PASS input.formMethod is ""
 PASS input.formTarget is ""
@@ -59,7 +58,6 @@ PASS input.getAttribute("formTarget") is "256"
 PASS input.formTarget is "256"
 
 Ordinary values for button:
-PASS button.formAction is ""
 PASS button.formEnctype is ""
 PASS button.formMethod is ""
 PASS button.formTarget is ""

third_party/WebKit/LayoutTests/fast/forms/submit-form-attributes.html

@@ -13,7 +13,6 @@ var input = document.createElement('input');
 
 debug('Ordinary values for input:');
 input.type = "submit";
-shouldBeEqualToString('input.formAction', '');
 shouldBeEqualToString('input.formEnctype', '');
 shouldBeEqualToString('input.formMethod', '');
 shouldBeEqualToString('input.formTarget', '');
@@ -110,7 +109,6 @@ var button = document.createElement('button');
 debug('');
 debug('Ordinary values for button:');
 button.type = "submit";
-shouldBeEqualToString('button.formAction', '');
 shouldBeEqualToString('button.formEnctype', '');
 shouldBeEqualToString('button.formMethod', '');
 shouldBeEqualToString('button.formTarget', '');

third_party/WebKit/Source/core/html/HTMLButtonElement.idl

@@ -24,7 +24,7 @@ interface HTMLButtonElement : HTMLElement {
     [Reflect] attribute boolean autofocus;
     [Reflect] attribute boolean disabled;
     [ImplementedAs=formOwner] readonly attribute HTMLFormElement? form;
-    [Reflect, URL] attribute DOMString formAction;
+    attribute DOMString formAction;
     attribute DOMString formEnctype;
     attribute DOMString formMethod;
     [Reflect] attribute boolean formNoValidate;

third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -34,6 +34,7 @@
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLegendElement.h"
 #include "core/html/ValidityState.h"
+#include "core/html/parser/HTMLParserIdioms.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/LayoutTheme.h"
@@ -85,6 +86,19 @@ DEFINE_TRACE(HTMLFormControlElement)
     LabelableElement::trace(visitor);
 }
 
+String HTMLFormControlElement::formAction() const
+{
+    const AtomicString& action = fastGetAttribute(formactionAttr);
+    if (action.isEmpty())
+        return document().url();
+    return document().completeURL(stripLeadingAndTrailingHTMLSpaces(action));
+}
+
+void HTMLFormControlElement::setFormAction(const AtomicString& value)
+{
+    setAttribute(formactionAttr, value);
+}
+
 String HTMLFormControlElement::formEnctype() const
 {
     const AtomicString& formEnctypeAttr = fastGetAttribute(formenctypeAttr);

third_party/WebKit/Source/core/html/HTMLFormControlElement.h

@@ -46,6 +46,8 @@ public:
     ~HTMLFormControlElement() override;
     DECLARE_VIRTUAL_TRACE();
 
+    String formAction() const;
+    void setFormAction(const AtomicString&);
     String formEnctype() const;
     void setFormEnctype(const AtomicString&);
     String formMethod() const;

third_party/WebKit/Source/core/html/HTMLInputElement.idl

@@ -36,7 +36,7 @@ interface HTMLInputElement : HTMLElement {
     // The 'files' attribute is intentionally not readonly.
     // https://www.w3.org/Bugs/Public/show_bug.cgi?id=22682
     attribute FileList? files;
-    [Reflect, URL] attribute DOMString formAction;
+    attribute DOMString formAction;
     [CustomElementCallbacks] attribute DOMString formEnctype;
     [CustomElementCallbacks] attribute DOMString formMethod;
     [Reflect] attribute boolean formNoValidate;