Commit ea91a195 authored by Sergey Ulanov's avatar Sergey Ulanov Committed by Commit Bot

[Fuchsia] Set correct vulkan usage flags in SysmemBufferCollection

Skia requires VK_IMAGE_USAGE_SAMPLED_BIT, VK_IMAGE_USAGE_TRANSFER_SRC_BIT
and VK_IMAGE_USAGE_TRANSFER_DST_BIT usage flags to be set for wrapped
Vulkan images. These flags were not set in SysmemBufferCollection for
buffers that were created with BufferUsage::SCANOUT usage. As result
these images couldn't be wrapped in Skia images. Update
SysmemBufferCollection::InitializeImageCreateInfo() to set the required
usage bits.

Bug: 1140763
Change-Id: If9e980701f109519eb25ce753251082c693eedf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488910
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819273}
parent d2c3a9fa
......@@ -446,7 +446,7 @@ void SysmemBufferCollection::InitializeImageCreateInfo(
VK_IMAGE_USAGE_TRANSFER_DST_BIT;
if (usage_ == gfx::BufferUsage::SCANOUT ||
usage_ == gfx::BufferUsage::SCANOUT_CPU_READ_WRITE) {
vk_image_info->usage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
vk_image_info->usage |= VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
}
vk_image_info->sharingMode = VK_SHARING_MODE_EXCLUSIVE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment