Disable cfi-icall for generated stubs

The generated stubs use dlsym()ed functions, so must not be instrumented
with CFI-icall.

BUG=1136413
R=sky

Change-Id: I698e6b3ed96349a2bb477767d54aeb9b3ad9096f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462216
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815379}

tools/generate_stubs/generate_stubs.py

@@ -92,6 +92,7 @@ FILE_TYPE_WIN_DEF = 'windows_def'
 #   arg_list: The arguments used to call the stub function.
 STUB_FUNCTION_DEFINITION = (
     """extern %(return_type)s %(name)s(%(params)s) __attribute__((weak));
+DISABLE_CFI_ICALL
 %(return_type)s %(export)s %(name)s(%(params)s) {
   %(return_prefix)s%(name)s_ptr(%(arg_list)s);
 }""")
@@ -110,6 +111,7 @@ STUB_FUNCTION_DEFINITION = (
 #                   argument.
 VARIADIC_STUB_FUNCTION_DEFINITION = (
     """extern %(return_type)s %(name)s(%(params)s) __attribute__((weak));
+DISABLE_CFI_ICALL
 %(return_type)s %(export)s %(name)s(%(params)s) {
   va_list args___;
   va_start(args___, %(last_named_arg)s);
@@ -131,6 +133,7 @@ VARIADIC_STUB_FUNCTION_DEFINITION = (
 #                   argument.
 VOID_VARIADIC_STUB_FUNCTION_DEFINITION = (
     """extern void %(name)s(%(params)s) __attribute__((weak));
+DISABLE_CFI_ICALL
 void %(export)s %(name)s(%(params)s) {
   va_list args___;
   va_start(args___, %(last_named_arg)s);
@@ -179,6 +182,8 @@ IMPLEMENTATION_PREAMBLE = """// This is generated file. Do not modify directly.
 
 #include <map>
 #include <vector>
+
+#include "base/compiler_specific.h"
 """
 
 # The start and end templates for the enum definitions used by the Umbrella

tools/generate_stubs/rules.gni

@@ -84,6 +84,10 @@ template("generate_stubs") {
                              "public_deps",
                              "visibility",
                            ])
+    if (!defined(deps)) {
+      deps = []
+    }
+    deps += [ "//base" ]
     if (!defined(public_deps)) {
       public_deps = []
     }