Commit eab4931f authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

Revert "IDL: Fix invalid extended attributes"

This reverts commit 5c872c1a.

Reason for revert: Postpone landing the CL to change APIs

Original change's description:
> IDL: Fix invalid extended attributes
> 
> An invliad extended attribute [Enabled] was used in IDLs of WebRTC,
> and some APIs are visible regardless a runtime enabled feature.
> This CL fixes the IDL description and hide them behind a flag.
> 
> 
> Bug: 999690, 986069
> Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Florent Castelli <orphis@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693038}

TBR=peria@chromium.org,hta@chromium.org,haraken@chromium.org,guidou@chromium.org,orphis@chromium.org

Change-Id: I9d2ddcdf6de7cb79139c5b6e15eb8920d6a34d98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 999690, 986069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783693Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693042}
parent 61d8ad80
......@@ -8,5 +8,5 @@ dictionary RTCRtpCodecCapability {
required unsigned long clockRate;
unsigned short channels;
DOMString sdpFmtpLine;
[RuntimeEnabled=RTCSvcScalabilityMode] sequence<DOMString> scalabilityModes;
[Enabled=RTCSvcScalabilityMode] sequence<DOMString> scalabilityModes;
};
......@@ -21,5 +21,5 @@ dictionary RTCRtpEncodingParameters : RTCRtpCodingParameters {
unsigned long maxBitrate;
//TODO(orphis): Missing maxFramerate. https://crbug.com/857047
double scaleResolutionDownBy;
[RuntimeEnabled=RTCSvcScalabilityMode] DOMString scalabilityMode;
[Enabled=RTCSvcScalabilityMode] DOMString scalabilityMode;
};
This is a testharness.js-based test.
FAIL Setting scalabilityMode to a legal value should be accepted assert_equals: expected (string) "L1T3" but got (undefined) undefined
FAIL Sender capabilities should include at least some scalability modes assert_true: expected true got false
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment